Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BPK-1153] Downgrade @storybook/react-native to fix issue #367

Merged
merged 1 commit into from
Dec 8, 2017

Conversation

shaundon
Copy link
Contributor

@shaundon shaundon commented Dec 7, 2017

The issue
When using storybook actions (or indeed any addons), we're getting an issue where triggering the action causes an error to appear.

The error message itself links to this page, which in turn links to this issue.

The solution
I tried all sorts of different changes to the code but I couldn't get it to work. In the end, through trial and error I figured out that downgrading @storybook/react-native by one patch version (3.2.17 ➡️ 3.2.16) sorts it out.

It's not an ideal long term solution, but it does fix things for now.

3.3.0 of Storybook is currently in alpha, I intend to next find out if that fixes the issue, and also find out what exactly changed from 3.2.16 to 3.2.17 to break things.

@backpackbot
Copy link

Messages
📖

Thanks for the PR 🎉.

Generated by 🚫 dangerJS

@shaundon
Copy link
Contributor Author

shaundon commented Dec 8, 2017

Just upgraded @storybook/react-native to 3.3.0-alpha.4 and it works there, although it does regress Android to the 'attempting to change value of a readonly property' bug we saw on 3.2.16.

So, assuming that the Android fix that was in 3.2.17 makes it to the final version of 3.3.0, upgrading upon release should hopefully fix our issue.

Copy link
Contributor

@georgegillams georgegillams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well caught!
Have you raised a Jira ticket to check future versions and re-upgrade? That way we won't forget to do it 😸

@shaundon shaundon merged commit 6dfc3ae into master Dec 8, 2017
@shaundon shaundon deleted the bpk-1153-fix-actions branch December 8, 2017 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants