From 7bd255783eba30b1bce2ea2b527e74770429a112 Mon Sep 17 00:00:00 2001 From: LawyZheng Date: Tue, 21 May 2024 10:40:07 +0800 Subject: [PATCH 1/2] skip required check on --- skyvern/webeye/scraper/domUtils.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/skyvern/webeye/scraper/domUtils.js b/skyvern/webeye/scraper/domUtils.js index 59ab78158..88be7d048 100644 --- a/skyvern/webeye/scraper/domUtils.js +++ b/skyvern/webeye/scraper/domUtils.js @@ -991,7 +991,8 @@ function buildTreeFromBody() { element.context = context; } - if (checkStringIncludeRequire(context)) { + // FIXME: skip for now to prevent navigating to other page by mistake + if (element.tagName !== "a" && checkStringIncludeRequire(context)) { if ( !element.attributes["required"] && !element.attributes["aria-required"] From b16c889e1b5fc7fffe4081e1ff5b3bed9a1eb8f6 Mon Sep 17 00:00:00 2001 From: LawyZheng Date: Tue, 21 May 2024 10:44:34 +0800 Subject: [PATCH 2/2] maxlength of non-interactable increase --- skyvern/webeye/scraper/domUtils.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/skyvern/webeye/scraper/domUtils.js b/skyvern/webeye/scraper/domUtils.js index 88be7d048..c5b8f76a2 100644 --- a/skyvern/webeye/scraper/domUtils.js +++ b/skyvern/webeye/scraper/domUtils.js @@ -758,8 +758,10 @@ function buildTreeFromBody() { } } - // character length limit for non-interactable elements should be 100 - if (textContent && textContent.length <= 100) { + // character length limit for non-interactable elements should be 5000 + // we don't use element context in HTML format, + // so we need to make sure we parse all text node to avoid missing text in HTML. + if (textContent && textContent.length <= 5000) { var elementObj = buildElementObject(element, false); elements.push(elementObj); if (parentId === null) {