Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support numpy=2.0.1? #36

Closed
ayaanhossain opened this issue Aug 2, 2024 · 4 comments
Closed

Support numpy=2.0.1? #36

ayaanhossain opened this issue Aug 2, 2024 · 4 comments

Comments

@ayaanhossain
Copy link

Hello, thank you for maintaining this useful project! Are there any plans to support numpy=2.0.1 in the near future?
@Sm00thix
Copy link
Owner

Sm00thix commented Aug 2, 2024

Hi @ayaanhossain!
I'm glad you like it 😄

Yes, supporting NumPy 2.0 is something I have wanted to do. I will soon make changes accordingly. I just need to ensure that it does not break any of the other dependencies 😄

@ayaanhossain
Copy link
Author

Awesome! Glad to hear! Please feel free to close this issue or close it once you've updated the support. I also hope that ikpls maintains backwards compatibility with numpy=1.26 as it does now as well.

@Sm00thix
Copy link
Owner

Sm00thix commented Aug 2, 2024

I will see what I can do to ensure backwards compatibility. I will close this issue once support for NumPy 2.0 is added 😄

@Sm00thix Sm00thix mentioned this issue Aug 5, 2024
Merged
@Sm00thix
Copy link
Owner

Sm00thix commented Aug 5, 2024

Closing this as completed since #37 added the functionality :-)

@Sm00thix Sm00thix closed this as completed Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Sm00thix @ayaanhossain