Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create unit tests #3

Open
bjuergens opened this issue Jan 25, 2018 · 1 comment
Open

create unit tests #3

bjuergens opened this issue Jan 25, 2018 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@bjuergens
Copy link
Collaborator

this guide suggests to use doctest.

Until now the testing is done manually via notebooks.

There should be some tests, that call the notebook from the commandline. This should be possible without modifying the module


Maybe there should also be some unit tests, that use the package as regular python-module, and not as ipython. This might require some changes. But at first glance, beside the registration with ipython, only 2 parts of the package require ipython:

  • shell for execution. This could be replaced by eval for non-ipython execution
  • display(HTML(...)) for tables. This could be replaced by "print" for non-ipython execution

The implementation would be like this: Those 2 things get moved function-parameters in the constructor, so the caller (e.g. the magics-class) has to supply them.

The real question is: Should it even be possible to use this module outside ipython?

@bjuergens bjuergens self-assigned this Jan 25, 2018
@bjuergens bjuergens added the enhancement New feature or request label Jan 25, 2018
@bjuergens bjuergens added this to the 1.1 milestone Aug 8, 2018
@bjuergens bjuergens removed their assignment Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant