Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SeatHandler is not needed #706

Closed
i509VCB opened this issue Aug 20, 2022 · 2 comments
Closed

SeatHandler is not needed #706

i509VCB opened this issue Aug 20, 2022 · 2 comments

Comments

@i509VCB
Copy link
Member

i509VCB commented Aug 20, 2022

SeatHandler's &SeatState is unused and therefore useless.

@i509VCB i509VCB added this to the v0.4: Gathering raw ores milestone Aug 20, 2022
@Drakulix
Copy link
Member

Drakulix commented Sep 2, 2022

Not really any more the case after #689, no?

@PolyMeilex
Copy link
Member

PolyMeilex commented Sep 2, 2022

Initially it was done to allow adding SeatState::seats() in the future, and the possibility to and some helpers like, last active seat, or whatever may be useful, So the need for Vec<Seat> in user's code would be mitigated.

My idea was something like this:

seat_state.add_seat(...); // Init new Seat global

seat_state.seats(); // Newly added seat is listed here

seat_state.remove_seat(...) // Disable/Remove Seat Global and remove it from the list

And coincidently Drakulix's changes align with that, as now seat_state is responsible for seat creation.

@i509VCB i509VCB closed this as completed Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants