Add forward-compatibility for new Beet versions #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependencies are still locked at their current version, but library consumers now have the flexibility to use higher `0.x` releases of Beet and related dependencies. Additionally `poetry.lock` uses the new format for Poetry 1.3.x, but 1.2.2 used by the GitHub Action is forwards-compatible with it so it should be fine.
The pinned version of Mecha seems to allow `run` to be omitted, but in new versions of Mecha this is not allowed and causes `beet build` to fail. Now the build should work with newer versions of Mecha.
|
Thanks for this! I think I try to use |
|
Hmm, i'm not sure what u mean that |
|
When I did `poetry update` and then tried to build, it errored due to
missing `run` in the locations I changed.
…On Wed, Feb 15, 2023, 17:14 Rit ***@***.***> wrote:
Hmm, i'm not sure what u mean that run needs to be included, the latest
versions of bolt allows for implicit runs?
—
Reply to this email directly, view it on GitHub
<#26 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJUDQRGEI6VUPTP7NBBVG73WXVIMVANCNFSM6AAAAAAU5FG4JA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
The latest command tree includes |
ahh, this makes a ton of sense 🤔 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the dependency specifications for Beet and related libraries to use
>=constraints instead of^to allow users who consumesmithed-librariesas a library to use newer Beet versions. The lock format now uses the1.3.xpoetry format but the GitHub action uses1.2.2which is forward-compatible with this format so it should be fine. Additionally, missingrunsubcommands have been added to a couple functions to avoid errors with the current Mecha version.Note that this PR does not update Beet, Mecha, etc. so GitHub actions should generate the same result as before. A new version is probably necessary for PyPI, but idk how to handle that.