From c05fa569d6fe229848e271d46ae968e1a9b74a44 Mon Sep 17 00:00:00 2001 From: Tiji Mathew Date: Fri, 22 Nov 2024 14:55:38 -0500 Subject: [PATCH] Leaving code comment to review later --- schemachange/config/DeployConfig.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/schemachange/config/DeployConfig.py b/schemachange/config/DeployConfig.py index 295839a..b42fc52 100644 --- a/schemachange/config/DeployConfig.py +++ b/schemachange/config/DeployConfig.py @@ -87,7 +87,9 @@ def get_session_kwargs(self) -> dict: "query_tag": self.query_tag } - #snowflake_password = get_snowflake_password() - #if snowflake_password is not None and snowflake_password: + # TODO: Discuss the need for check for snowflake password before passing the session + # kwargs to open a snowflake session + # snowflake_password = get_snowflake_password() + # if snowflake_password is not None and snowflake_password: # session_kwargs["password"] = snowflake_password return {k: v for k, v in session_kwargs.items() if v is not None}