Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Support for schema syncing via cli #196

Closed
wants to merge 2 commits into from

Conversation

yakshup
Copy link

@yakshup yakshup commented Sep 14, 2023

Extending #180 with cli options and tracking in change history

@sfc-gh-tmathew sfc-gh-tmathew added question Further information is requested Under Review This is being discussed without planned changes labels Nov 2, 2023
@sfc-gh-tmathew sfc-gh-tmathew self-assigned this Nov 2, 2023
@sfc-gh-tmathew
Copy link
Collaborator

@yakshup By adding the schema column without the altering the table structure will result in failure. This will also require documentation updates and ensure that existing users of schemachange do not loose the change history when upgrading to a release that includes this change. This cannot be accepted in its current state and needs more work.

@podung
Copy link
Contributor

podung commented Nov 14, 2023

Sorry all - I didn't see this PR hanging off my original. I finally have my original fully up to date and ready to commit, though I needed to open a new PR: #210 .

It has tests, documentation, cli support, and yml config support

@podung
Copy link
Contributor

podung commented Nov 14, 2023

On the additional specific effort in #196, I'm not exactly clear what was being attempted. @yakshup can you elaborate on what use case you were trying to support by wanting to track a schema column on the change history table?

@yakshup
Copy link
Author

yakshup commented Nov 17, 2023

On the additional specific effort in #196, I'm not exactly clear what was being attempted. @yakshup can you elaborate on what use case you were trying to support by wanting to track a schema column on the change history table?

@podung We had a requirement to track changes per schema on which changes are made. I believe this was something which was raised in #180.

@sfc-gh-tmathew sfc-gh-tmathew added wontfix This will not be worked on and removed question Further information is requested Under Review This is being discussed without planned changes labels Mar 13, 2024
@sfc-gh-tmathew
Copy link
Collaborator

Thank you for contributions but we will not be including this change to the schemachange feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants