Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add fix for model grants #3070

Merged
merged 1 commit into from
Sep 17, 2024
Merged

fix: Add fix for model grants #3070

merged 1 commit into from
Sep 17, 2024

Conversation

sfc-gh-jcieslak
Copy link
Collaborator

Changes

@github-actions GitHub Actions
Copy link

Integration tests failure for 58ea0a24e5f91c0c7268fe474e28fde55f3a0c78

@sfc-gh-jcieslak sfc-gh-jcieslak merged commit cbc3d74 into main Sep 17, 2024
8 of 9 checks passed
@sfc-gh-jcieslak sfc-gh-jcieslak deleted the handle-models-in-grants branch September 17, 2024 12:04
@snowflake-release-please snowflake-release-please bot mentioned this pull request Sep 17, 2024
Merged
sfc-gh-fbudzynski pushed a commit that referenced this pull request Sep 19, 2024
@sfc-gh-jcieslak @sfc-gh-fbudzynski
fix: Add fix for model grants (#3070)
e0b978a 
## Changes
- Address the issue:
#3050
about granting usage on future models (I couldn't provide the test on
non-future model because the only way of creating such model is with
python snowpark and it's not that easy, I tried).
- Fix other failing test in grants.
sfc-gh-jmichalak pushed a commit that referenced this pull request Sep 19, 2024
@snowflake-release-please
chore(main): release 0.96.0 (#3042)
18f2ce4 
🤖 I have created a release *beep* *boop*
---


##
[0.96.0](v0.95.0...v0.96.0)
(2024-09-18)

Essential GA object readiness for V1:
[link](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/v1-preparations/ESSENTIAL_GA_OBJECTS.MD)
([Roadmap
reference](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/ROADMAP.md#preparing-essential-ga-objects-for-the-provider-v1)).

:exclamation: Migration guide: [v0.95.0 ->
v0.96.0](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/MIGRATION_GUIDE.md#v0950--v0960)

### 🎉 **What's new:**

* V1 redesign of resources and data sources
* Row access policy
([#3066](#3066))
([#3063](#3063))
* Resource monitor
([#3052](#3052))
([#3064](#3064))
* Masking policy
([#3078](#3078))
([#3083](#3083))
* SDK upgrades
* External volume
([#3033](#3033))
* Authentication policy
([#2937](#2937))
([#3068](#3068))
([#3061](#3061))


### 🔧 **Misc**

* Clean up old test object helpers
([#3049](#3049))
* Add example of granting role to multiple objects
([#3047](#3047))
* Update readme and objects rework state
([#3046](#3046))

### 🐛 **Bug fixes:**

* Fix model grants
([#3070](#3070))
* Fix database show by and resource logic
([#3055](#3055))
* Fix default secondary roles option import
([#3041](#3041))
* Fix sweepers for warehouse and database
([#3057](#3057))
* Fix views permadiff
([#3079](#3079))
* Update v0.95.0 migration guide
([#3062](#3062))

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-jmichalak sfc-gh-jmichalak sfc-gh-jmichalak approved these changes

@sfc-gh-asawicki sfc-gh-asawicki sfc-gh-asawicki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-jcieslak @sfc-gh-asawicki @sfc-gh-jmichalak