Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Test more authentication methods #3178

Merged
merged 4 commits into from
Nov 8, 2024
Merged

chore: Test more authentication methods #3178

merged 4 commits into from
Nov 8, 2024

Conversation

sfc-gh-jmichalak
Copy link
Collaborator

@sfc-gh-jmichalak sfc-gh-jmichalak commented Nov 7, 2024 •
edited
Loading

  • add a test for JWT authentication (skipped for now; it needs a configuration adjustment and this will be done in the next PR)
  • add a test for Okta
  • add a test for session parameters
  • move driver log level to sdk
  • add tests for Mfa with and without passcode
  • fix conflicting fields in view resource
  • bring back configuring logging level for internal client tests
  • describe all of the manual test steps in a readme

Test Plan

  • acceptance tests
  • …

TODO

  • (next pr) read a compatible config file for older versions in acc tests, adjust the configurations in Github secrets and our secret storage, and unskip the relevant tests
  • Other authentication methods will be done in SNOW-1791729.

@sfc-gh-jmichalak sfc-gh-jmichalak changed the title Test more authentication methods chore: Test more authentication methods Nov 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Integration tests cancelled for e6a7f8e32176650faf9adfb93e2847ba1cb71ea8

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Integration tests failure for a19504b830744a4c36663c50391c5d702363b12c

@sfc-gh-jmichalak sfc-gh-jmichalak marked this pull request as ready for review November 7, 2024 15:27
@sfc-gh-jmichalak sfc-gh-jmichalak requested review from sfc-gh-asawicki and sfc-gh-jcieslak and removed request for sfc-gh-asawicki November 7, 2024 15:27
sfc-gh-jmichalak
sfc-gh-jmichalak commented Nov 7, 2024
View reviewed changes
pkg/provider/provider_acceptance_test.go
// authenticate with unencrypted private key with a legacy authenticator value
// solves https://github.com/Snowflake-Labs/terraform-provider-snowflake/issues/2983
{
Config: providerConfigWithAuthenticator("jwt_test", sdk.AuthenticationTypeJwtLegacy),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is moved to testprofiles in the next pr.

sfc-gh-asawicki
sfc-gh-asawicki requested changes Nov 8, 2024
View reviewed changes
pkg/provider/manual_tests/README.md Outdated Show resolved Hide resolved
pkg/sdk/client.go Outdated Show resolved Hide resolved
pkg/sdk/internal/client/client_test.go Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024

Integration tests failure for fa78ceea83814eadba0d5a0d155c39b4b66e7d09

@sfc-gh-asawicki sfc-gh-asawicki self-requested a review November 8, 2024 12:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024

Integration tests cancelled for 2c4554ce47efbde31d2c6ba8fa79b5d0675a5232

@sfc-gh-jmichalak sfc-gh-jmichalak merged commit d345cd2 into main Nov 8, 2024
8 of 9 checks passed
@sfc-gh-jmichalak sfc-gh-jmichalak deleted the config-rework branch November 8, 2024 12:25
@snowflake-release-please snowflake-release-please bot mentioned this pull request Nov 8, 2024
Merged
sfc-gh-jmichalak pushed a commit that referenced this pull request Nov 8, 2024
@snowflake-release-please
chore(main): release 0.98.0 (#3137)
003999e 
##
[0.98.0](v0.97.0...v0.98.0)
(2024-11-08)

Feature scope readiness for V1:
[link](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/v1-preparations/ESSENTIAL_GA_OBJECTS.MD)
([Roadmap
reference](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/ROADMAP.md#wrap-up-the-functional-scope)).
:exclamation: Migration guide: [v0.97.0 ->
v0.98.0](https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/MIGRATION_GUIDE.md#v0970--v0980)

### 🎉 What's new
- New resources:
- authentication_policy
([#3098](#3098)),
references
[#2880](#2880)
- external_volume
([#3106](#3106)),
partially references
[#2980](#2980)
- stream_on_directory_table
([#3129](#3129))
- stream_on_view
([#3150](#3150))
- primary_connection, secondary_connection
([#3162](#3162))
- secret_with_basic_authentication, secret_with_generic_string,
secret_with_oauth_authorization_code_grant,
secret_with_oauth_client_credentials
([#3110](#3110)),
([#3141](#3141))
- New data sources:
- connections
([#3155](#3155)),
([#3173](#3173))
- secrets
([#3131](#3131))
- Reworked:
- provider configuration hierarchy
([#3166](#3166)),
references
[#1881](#1881),
[#2145](#2145),
[#2925](#2925),
[#2983](#2983),
[#3104](#3104)
- provider configuration fields
([#3152](#3152))
streams data source
([#3151](#3151))
- SDK upgrades:
- Upgrade tag SDK
([#3126](#3126))
- Recreate streams when they are stale
([#3129](#3129))
### 🔧  Misc
- Add object renaming research summary
([#3172](#3172))
- Test support for object renaming
([#3130](#3130)),
([#3147](#3147)),
([#3154](#3154))
- Add tests to issue
[#3117](#3117)
([#3133](#3133))
- New roadmap entry
([#3158](#3158))
- Test more authentication methods
([#3178](#3178))
- Minor fixes
([#3174](#3174))
### 🐛  Bug fixes
- Apply various fixes
([#3176](#3176)),
this addresses BCR 2024_08, references
[#2717](#2717),
[#3005](#3005),
[#3125](#3125),
[#3127](#3127),
[#3153](#3153)
- Connection and secret data sources tests
([#3177](#3177))
- Fix grant import docs
([#3183](#3183)),
resolves
[#3179](https://github.com/Snowflake-Labs/terraform-provider-snowflake/discussions/3179)
- Fix user resource import
([#3181](#3181))
- Handle external type changes in stream resources
([#3164](#3164))
- Do not use OR REPLACE on initial creation in resources with
copy_grants
([#3129](#3129))
- Address issue
[#2201](#2201)
by introducing new stream resources

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-asawicki sfc-gh-asawicki sfc-gh-asawicki approved these changes

@sfc-gh-jcieslak sfc-gh-jcieslak sfc-gh-jcieslak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-jmichalak @sfc-gh-jcieslak @sfc-gh-asawicki