Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: parser and secret tests #3192

Merged
merged 2 commits into from
Nov 14, 2024
Merged

chore: parser and secret tests #3192

merged 2 commits into from
Nov 14, 2024

Conversation

sfc-gh-fbudzynski
Copy link
Collaborator

@sfc-gh-fbudzynski sfc-gh-fbudzynski commented Nov 12, 2024 •
edited
Loading

Changes

  • added ../ to primary_connection documentation
  • added invalid test cases for ParseCommaSeparatedAccountIdentifierArray
  • changed secretsData() function parameters

Test Plan

  • acceptance tests for secrets
  • unit tests for parser

References

references to comments:

@sfc-gh-fbudzynski sfc-gh-fbudzynski marked this pull request as ready for review November 12, 2024 14:54
@github-actions GitHub Actions
Copy link

Integration tests failure for a677547ac24c7b3f4d470b6f5fa3541341581fc0

@github-actions GitHub Actions
Copy link

Integration tests failure for 1954a03cd888d63c70081f23e98438652c28cfad

@sfc-gh-asawicki sfc-gh-asawicki self-requested a review November 14, 2024 10:41
@sfc-gh-fbudzynski sfc-gh-fbudzynski merged commit 5ec9c86 into main Nov 14, 2024
8 of 9 checks passed
@sfc-gh-fbudzynski sfc-gh-fbudzynski deleted the chore-parse-account-id branch November 14, 2024 10:50
@snowflake-release-please snowflake-release-please bot mentioned this pull request Nov 14, 2024
Merged
sfc-gh-jmichalak pushed a commit that referenced this pull request Nov 26, 2024
@snowflake-release-please
chore(main): release 0.99.0 (#3201)
57c0c2c 
🤖 I have created a release *beep* *boop*
---


##
[0.99.0](v0.98.0...v0.99.0)
(2024-11-26)


### 🎉 **What's new:**

* Add tags data source
([#3211](#3211))
([8907d9d](8907d9d))
* Tag resource v1
([#3197](#3197))
([77b3bf0](77b3bf0))
* Tasks v1 readiness
([#3222](#3222))
([e2284d9](e2284d9))


### 🔧 **Misc**

* Add support for usage tracking to data sources
([#3224](#3224))
([8210bb8](8210bb8))
* Add usage tracking for the rest of the resources and fix views
([#3223](#3223))
([231f653](231f653))
* Basic object tracking
([#3205](#3205))
([1f0dc94](1f0dc94))
* basic object tracking part 2
([#3214](#3214))
([e44f2e1](e44f2e1))
* Improve tags integration tests
([#3193](#3193))
([7736e0a](7736e0a))
* parser and secret tests
([#3192](#3192))
([5ec9c86](5ec9c86))
* Storage integration with custom protocol
([#3213](#3213))
([a3a44ae](a3a44ae))
* Unskip auth config tests
([#3180](#3180))
([46ab142](46ab142))


### 🐛 **Bug fixes:**

* Small fixes and adjustments
([#3226](#3226))
([9f67457](9f67457))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-jmichalak sfc-gh-jmichalak sfc-gh-jmichalak approved these changes

@sfc-gh-asawicki sfc-gh-asawicki sfc-gh-asawicki approved these changes

@sfc-gh-jcieslak sfc-gh-jcieslak sfc-gh-jcieslak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-fbudzynski @sfc-gh-jcieslak @sfc-gh-asawicki @sfc-gh-jmichalak