fix: Fixes in account parameters #3310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-asawicki
approved these changes
Dec 20, 2024
| CheckDestroy: acc.CheckAccountParameterUnset(t, sdk.AccountParameterRequireStorageIntegrationForStageCreation), | ||
| Steps: []resource.TestStep{ | ||
| { | ||
| Config: config.FromModel(t, model), |
There was a problem hiding this comment.
We'll have problem here because in #3307 this method is completely removed (because it was deprecated). Instead, FromModels should be used. But we can do a quick follow-up after both merges.
|
Integration tests failure for 1d575ac6dc5b73a227022ffd2a8dc0df2afae3a4 |
sfc-gh-asawicki
approved these changes
Dec 20, 2024
|
Integration tests cancelled for a2355f53a6612793efdd36bd7a2782ff77efa9cb |
sfc-gh-asawicki
pushed a commit
that referenced
this pull request
Dec 20, 2024
<!-- Feel free to delete comments as you fill this in --> - Add missing parameters based on the docs and output of SHOW PARAMETERS IN ACCOUNT - Add missing unit tests and implementations - Add missing validations - Relax validations for ints - just validate if they are non-negative - Update docs <!-- summary of changes --> ## Test Plan <!-- detail ways in which this PR has been tested or needs to be tested --> * [ ] acceptance tests <!-- add more below if you think they are relevant --> * [ ] … ## References <!-- issues documentation links, etc --> #3044 #3116 #3245 ## TODO - Do not add missing user parameters - this will be done in SNOW-1844996. Here, they are added only to account and session level - More acceptance and integration tests should be done on a separate account. This should be done during account resource follow-up (SNOW-1866453)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan
References
#3044
#3116
#3245
TODO