Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using host function for keccak_512 in ethereum light client #157

Closed
musnit opened this issue Nov 12, 2020 · 2 comments
Closed

Consider using host function for keccak_512 in ethereum light client #157

musnit opened this issue Nov 12, 2020 · 2 comments
Labels
optimization performance

Comments

@musnit
Copy link
Collaborator

musnit commented Nov 12, 2020

We currently run our hashing via code in our parachain wasm binary. Ideally polkadot would add this as a host function we can use directly. If they do this, then we should port over to using it.

Comment on our PR: #147 (comment)
Comment on Substrate keccak: paritytech/substrate@510e68b
@tomusdrw
Copy link

Substrate PR to track: paritytech/substrate#7531

@Rizziepit
Copy link
Collaborator

This is sorted out. I switched to sp_io::hashing::keccak_512 in 562de76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
optimization performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tomusdrw @Rizziepit @musnit