Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[invader-refactor] Exclude explicitly set names from -R #203

Open
Aerocatia opened this issue Apr 20, 2021 · 1 comment
Open

[invader-refactor] Exclude explicitly set names from -R #203

Aerocatia opened this issue Apr 20, 2021 · 1 comment
Labels
invader-refactor This has to do with invader-refactor

Comments

@Aerocatia
Copy link
Collaborator

Aerocatia commented Apr 20, 2021

The find and replace feature should ignore names set in the same command.
For example invader-refactor -M move -r foo/bar foo/baz -R baz foobar will result in "foo/baz" being called "foo/foobar"

While this logically makes sense, it is counter intuitive to have it stomp over something you just explicitly set.

@Aerocatia Aerocatia added the invader-refactor This has to do with invader-refactor label Apr 20, 2021
@Aerocatia
Copy link
Collaborator Author

Aerocatia commented Apr 20, 2021

Here is a better example of this biting you:
invader-refactor -M copy -r foo/bar foo/bar_custom -R bar bar_custom
foo/bar -> foo/bar_custom_custom

@SnowyMouse SnowyMouse added this to the Complete Editing Kit milestone Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invader-refactor This has to do with invader-refactor
Projects
None yet
Development

No branches or pull requests

2 participants