Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

card UX improvement #379

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

card UX improvement #379

wants to merge 1 commit into from

Conversation

zbarnz
Copy link
Member

@zbarnz zbarnz commented Dec 1, 2022

Description

Added a little indication that you can edit takeaways and action items

chrome-capture-2022-11-1

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

took 5 seconds to make sure it worked

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

removed unused styles
Comment on lines +22 to +23
border-radius: 5px;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In scss you can also do &:hover within the .name block.

@thudsonbu
Copy link
Member

This is definitely an improvement over what we have now but I think it might be better to have the entire card become highlighted. I think that having the individual fields be highlighted implies that you will only be editing that field. Thoughts?

@thudsonbu thudsonbu assigned zbarnz and unassigned thudsonbu Dec 1, 2022
Copy link
Contributor

@Dahvd Dahvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link
Member

@thudsonbu thudsonbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this to the other cards? It would also be cool if the field you clicked on was what was autoFocused on if it isn't too difficult.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants