Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

card UX improvement #379

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

card UX improvement #379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions www/components/pages/Meet/ActionItemCard/ActionItemCard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ export default function ActionItemCard({
<div className={styles.content_container}>
<TextField
autoFocus
className={`${styles.name_input} ${styles.input}`}
className={`${styles.input}`}
fullWidth
size="small"
label="Name"
Expand All @@ -119,7 +119,7 @@ export default function ActionItemCard({
value={name}
/>
<TextField
className={`${styles.description} ${styles.input}`}
className={`${styles.input}`}
multiline
minRows={3}
fullWidth
Expand Down
10 changes: 10 additions & 0 deletions www/components/pages/Meet/ActionItemCard/ActionItemCard.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,20 @@

.name {
margin-bottom: 1em;
border-radius: 5px;
}
Comment on lines +22 to +23
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In scss you can also do &:hover within the .name block.


.name:hover {
background-color: var(--foregroundHighlight);
}

.description {
margin-bottom: 1em;
border-radius: 5px;
}

.description:hover {
background-color: var(--foregroundHighlight);
}

.input {
Expand Down
4 changes: 2 additions & 2 deletions www/components/pages/Meet/TakeawayCard/TakeawayCard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export default function TakeawayCard({ takeaway, deleteUnsaved, className }) {
<div className={styles.content_container}>
<TextField
autoFocus
className={`${styles.name_input} ${styles.input}`}
className={`${styles.input}`}
fullWidth
size="small"
label="Name"
Expand All @@ -94,7 +94,7 @@ export default function TakeawayCard({ takeaway, deleteUnsaved, className }) {
value={name}
/>
<TextField
className={`${styles.description} ${styles.input}`}
className={`${styles.input}`}
multiline
minRows={3}
fullWidth
Expand Down
10 changes: 10 additions & 0 deletions www/components/pages/Meet/TakeawayCard/TakeawayCard.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,20 @@

.name {
margin-bottom: 1em;
border-radius: 5px;
}

.name:hover {
background-color: var(--foregroundHighlight);
}

.description {
margin-bottom: 1em;
border-radius: 5px;
}

.description:hover {
background-color: var(--foregroundHighlight);
}

.input {
Expand Down
1 change: 1 addition & 0 deletions www/styles/globals.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ p {
--background: #f5f5f5;
--backgroundHighlight: #e6e6e6;
--foreground: #fff;
--foregroundHighlight: #f3f3f3;
--border: #c9c9c9;
--darkText: #3a3c45;
--midText: #6a737d;
Expand Down