Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dpp): add epds survey on app #162

Merged
merged 9 commits into from
Apr 27, 2021
Merged

Conversation

yannickjacqueline
Copy link
Contributor

Pour l'instant, j'ai ajouté 3 questions et réponses en dur dans l'app, et l'écran de résultats affiche simplement "Résultats".
Lorsque j'aurai terminé de mettre les questions et réponses dans le back, j'ajouterai la notion de points pour adapter le résultat

@yannickjacqueline yannickjacqueline changed the title Add epds survey feat(dpp) Add epds survey Apr 23, 2021
@yannickjacqueline yannickjacqueline changed the title feat(dpp) Add epds survey feat(dpp): add epds survey on app Apr 23, 2021
front/constants/Labels.ts Outdated Show resolved Hide resolved
front/constants/Labels.ts Outdated Show resolved Hide resolved
front/screens/EpdsSurveyScreen.tsx Outdated Show resolved Hide resolved
front/screens/EpdsSurveyScreen.tsx Outdated Show resolved Hide resolved
front/screens/EpdsSurveyScreen.tsx Outdated Show resolved Hide resolved
front/screens/EpdsSurveyScreen.tsx Outdated Show resolved Hide resolved
front/screens/EpdsSurveyScreen.tsx Show resolved Hide resolved
front/screens/EpdsSurveyScreen.tsx Outdated Show resolved Hide resolved
}
});

export default EpdsSurveyScreen;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ce fichier commence à être assez gros. Il pourrait être divisé en plusieurs composants, par exemple en créant un composant pour une réponse et/ou un composant qui contient la question et une liste de réponses

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je m'occupe de ça

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yannickjacqueline Possible de faire diviser ce fichier en plusieurs composants ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouais je vais faire déjà un composant qui affiche une question et ses réponses, et voire un deuxième composant qui va gérer le SwiperFlatList

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Du coup, j'ai fait un composant EpdsQuestion pour afficher une question avec ses réponses, et un EpdsFooter pour afficher les boutons, il prenait pas mal de places aussi. Et j'ai fait du ménage dans les styles aussi
Et faut savoir aussi que quand demain je brancherai le questionnaire au back, le tableau de questions/réponses déclaré au début va partir aussi donc ça fera des lignes en moins.

Je te laisse jeter un coup d'oeil et on pourra merger si t'es OK

front/screens/EpdsSurveyScreen.tsx Outdated Show resolved Hide resolved
front/constants/Labels.ts Outdated Show resolved Hide resolved
yannickjacqueline and others added 2 commits April 26, 2021 18:13
Co-authored-by: Benjamin Morali <benjaminmorali4@hotmail.fr>
@yannickjacqueline yannickjacqueline merged commit 384583f into master Apr 27, 2021
@yannickjacqueline yannickjacqueline deleted the add-epds-survey branch April 27, 2021 07:29
SocialGroovyBot added a commit that referenced this pull request Apr 27, 2021
# [1.16.0](v1.15.1...v1.16.0) (2021-04-27)

### Features

* **dpp:** add epds survey on app ([#162](#162)) ([384583f](384583f))
@SocialGroovyBot
Copy link
Member

🎉 This PR is included in version 1.16.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants