Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar icons blurry #4328

Closed
1 of 3 tasks
yw4z opened this issue Mar 4, 2024 · 5 comments · Fixed by #4552
Closed
1 of 3 tasks

Toolbar icons blurry #4328

yw4z opened this issue Mar 4, 2024 · 5 comments · Fixed by #4552
Labels
bug Something isn't working

Comments

@yw4z
Copy link
Contributor

yw4z commented Mar 4, 2024

Is there an existing issue for this problem?

  • I have searched the existing issues

OrcaSlicer Version

2.0

Operating System (OS)

Windows

OS Version

10 LTSC

Additional system information

No response

Printer

Creality K1

How to reproduce

Changing window width aligns toolbar to perfect center that makes start point of toolbar as float number instead of int. that causes blurry images

Actual results

here is comparison of perfect fit vs slightly shifted blurry icons

Screenshot-20240304024011

i changed window width few times to catch perfect fit

Expected results

i guess current placement of toolbar if sidebar on left
start_point_of_toolbar = ((window_width - sidebar_width ) / 2 )- (toolbar_width / 2)

number should be convert to "int" after calculation to fix that otherwise window tries to render toolbar start with decimal numbers and that causes blurry images

Project file & Debug log uploads

Checklist of files to include

  • Log file
  • Project file

Anything else?

No response

@yw4z yw4z added the bug Something isn't working label Mar 4, 2024
@discip
Copy link
Contributor

discip commented Mar 8, 2024

@Noisyfox
Could you have a look please? 😊

@yw4z
Copy link
Contributor Author

yw4z commented Mar 8, 2024

also i found toolbar > emboss > text alignment and style buttons blurry. these could be related with this issue

@Noisyfox
Copy link
Collaborator

Noisyfox commented Mar 8, 2024

Sure I'll take a look soon. BTW thanks for your icon rework, that's amazing~

@yw4z
Copy link
Contributor Author

yw4z commented Mar 8, 2024

Thanks for your efforts on orca, way better than other ones. just wanted to help on project to make it better

@yw4z
Copy link
Contributor Author

yw4z commented Mar 13, 2024

@Noisyfox
i dont know how to build to test but i guess this line should be int instead float. same should be done for "top"

float left = 2.0f * m_layout.left * inv_cnv_w;

float left = u_offset + (float)render_state * du;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants