Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kaminari conflict (in smart_listing) #8

Open
ndbroadbent opened this issue Oct 22, 2017 · 5 comments
Open

kaminari conflict (in smart_listing) #8

ndbroadbent opened this issue Oct 22, 2017 · 5 comments

Comments

@ndbroadbent
Copy link

ndbroadbent commented Oct 22, 2017

I've had a quick look at the ng branches in maily_herald and maily_herald-webui, and tried to get them running with my Rails 5 app. I couldn't get past a kaminari version conflict with the smart_listing gem. This issue has been raised over on the smart_listing project.

I'm using the activeadmin gem, which depends on kaminari >= 1.0.1.

I tried to fork smart_listing and update the dependencies, but I was unable to get the tests to pass on Ruby 2.1.3. And Ruby 2.4.2 requires a big update of all the dependencies (updating to Rails 5.)

So I'm blocked on this for now, but am opening an issue here because I can't wait to use maily_herald in my app. (Especially the web UI.)

@BlazPerus
Copy link

BlazPerus commented Feb 11, 2018

It breaks for me too.

Can you please update the dependencies on kaminari (~> 0.16.1) please? (smart_listing gem)

@BlazPerus
Copy link

@ljachymczyk

@ardahaal
Copy link
Contributor

Hi guys, there's a PR Sology/smart_listing#139 and it should be merged soon, we'll let you know when it's done.

@BlazPerus
Copy link

Any updates on this?

@n-rodriguez
Copy link

Hi there! Any news?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants