Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smart_listing.paginate broke with Ruby 3.1.1 #211

Open
xungngo opened this issue Apr 13, 2022 · 3 comments
Open

smart_listing.paginate broke with Ruby 3.1.1 #211

xungngo opened this issue Apr 13, 2022 · 3 comments

Comments

@xungngo
Copy link

xungngo commented Apr 13, 2022 •
edited

<%= smart_listing.paginate %>
Resulted in wrong number of arguments (given 2, expected 1)

TRACE:
[kaminari-core (1.2.2) lib/kaminari/helpers/helper_methods.rb:116:in `paginate']

[smart_listing (1.2.3) app/helpers/smart_listing/helper.rb:49:in `paginate']
@dannyvanhoof
Copy link

looks like since ruby 3, a ** is needed in front of the options dictionary:

@template.paginate @smart_listing.collection, **{:remote => @smart_l...

@moirazz
Copy link

moirazz commented Feb 1, 2023

any update on this issue? I'm running into the same thing

@xungngo
Copy link
Author

xungngo commented Feb 1, 2023

What dannyvanhoof said above BUT I would abandon this kind of gems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dannyvanhoof @xungngo @moirazz