Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add C#9 test cases for cross-rule classes #3671

Closed
2 tasks done
andrei-epure-sonarsource opened this issue Oct 26, 2020 · 2 comments · Fixed by #3770
Closed
2 tasks done

Add C#9 test cases for cross-rule classes #3671

andrei-epure-sonarsource opened this issue Oct 26, 2020 · 2 comments · Fixed by #3770
Assignees
@andrei-epure-sonarsource

Comments

@andrei-epure-sonarsource
Copy link
Contributor

andrei-epure-sonarsource commented Oct 26, 2020 •
edited
Loading

  • - Generated code detection
  • CSharpExecutableLinesMetric
@andrei-epure-sonarsource andrei-epure-sonarsource changed the title Add test cases for cross-rule classes Add C#9 test cases for cross-rule classes Oct 29, 2020
@andrei-epure-sonarsource
Copy link
Contributor Author

this should be done after #3668

@andrei-epure-sonarsource
Copy link
Contributor Author

Note that I removed from the initial scope:

  • usages of IPropertySymbol GetMethod and SetMethod because Init is just a Set
  • usages of ITypeSymbol IsClass or IsStruct because Record is just a Class
  • CSharpLiveVariableAnalysis.cs because it's covered by the DeadStores tests
  • Sonar-Security C# FE ... we said we'll do it separately

Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrei-epure-sonarsource andrei-epure-sonarsource

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add C#9 tests for generated code detection and executable line metrics SonarSource/sonar-dotnet
2 participants
@andrei-epure-sonarsource @pavel-mikula-sonarsource