Fix S3900 FP: assigned parameters

[zsolt-kolbay-sonarsource]

Fixes #6972
Fixes #3400

[MaStr11]

More tests are needed.

[antonioaversa]

Very good improvement for S3900, solves quite a few FP!
I have just some minor remarks, mostly cosmetics.
@martin-strecker-sonarsource already identified pretty much all the interesting scenarios which would be good to have here.

[martin-strecker-sonarsource]

You accidentally delete some code after re-basing which caused a lot of changes in the ITs. You need to revert the line and re-create the ITs.
Test coverage looks good now.

[antonioaversa]

LGTM: all my remarks have been addressed.
Martin's ones to be addressed.

[martin-strecker-sonarsource]

Some more corrections.

[martin-strecker-sonarsource]

This looks good:
https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/sources/Ember-MM/Ember%20Media%20Manager/clsTheming.vb#L164-L169

The issue, raised in line 164 is still there as it should.

[martin-strecker-sonarsource]

Both are TN:

sonar-dotnet/analyzers/its/sources/Ember-MM/Ember.Plugins/Utility.cs

Lines 34 to 51 in e641f52

	public static string SanitiseIMDbId(string imdbId)
	{
	if (string.IsNullOrEmpty(imdbId) || imdbId.Trim().Length == 0)
	return string.Empty;
	imdbId = imdbId.Trim();
	if ("tt".Equals(imdbId))
	imdbId = string.Empty;
	else
	{
	if (!imdbId.StartsWith("tt"))
	imdbId = string.Concat("tt", imdbId);
	if (imdbId.Length != 9)
	imdbId = string.Empty;
	}
	return imdbId;
	}

[martin-strecker-sonarsource]

All issues are gone except the first one on line 112

sonar-dotnet/analyzers/its/sources/Ember-MM/EmberAPI/clsAPIFileUtils.vb

Lines 111 to 122 in e641f52

	Public Shared Function MakeValidFilename(ByVal filename As String) As String
	filename = filename.Replace(":", " -")
	filename = filename.Replace("/", String.Empty)
	'pattern = pattern.Replace("\", String.Empty)
	filename = filename.Replace("|", String.Empty)
	filename = filename.Replace("<", String.Empty)
	filename = filename.Replace(">", String.Empty)
	filename = filename.Replace("?", String.Empty)
	filename = filename.Replace("*", String.Empty)
	filename = filename.Replace(" ", " ")
	Return filename
	End Function

[martin-strecker-sonarsource]

Here too:

sonar-dotnet/analyzers/its/sources/Ember-MM/Addons/scraper.EmberCore.XML/XMLScraper/Utilities/Util.vb

Lines 186 to 197 in e641f52

	Public Shared Function FixParse(ByVal value As String) As String
	value = value.Replace("&", "&")
	value = value.Replace("&", "&")
	value = value.Replace("&", "&&")
	value = value.Replace("&#", "&#")
	value = value.Replace(""", """)
	value = value.Replace("<", "<")
	value = value.Replace(">", ">")
	value = value.Replace("'", "'")
	Return value
	End Function

[martin-strecker-sonarsource]

TN (reassign in line 148)

sonar-dotnet/analyzers/its/sources/Nancy/src/Nancy/Helpers/HttpUtility.cs

Line 192 in e641f52

return e.GetString(buf);

[martin-strecker-sonarsource]

TN:

sonar-dotnet/analyzers/its/sources/akka.net/src/core/Akka.Remote.TestKit/MultiNodeSpec.cs

Lines 546 to 549 in e641f52

	public void MuteDeadLetters(ActorSystem system = null, params Type[] messageClasses)
	{
	if (system == null) system = Sys;
	if (!system.Log.IsDebugEnabled)

[martin-strecker-sonarsource]

LGTM. Please fix the comment if appropriate and create a follow-up issue for the remaining operations or reuse an existing issue for the tracking.

[martin-strecker-sonarsource]

I think "assignment with flow capture" is missing here, right?

Suggested change

	// Missing operation types: DeconstructionAssignment, CoalesceAssignment, CompoundAssignment, ThrowExpression
	// Missing operation types: DeconstructionAssignment, CoalesceAssignment, CompoundAssignment, ThrowExpression, assignment with flow capture

[martin-strecker-sonarsource]

Do we have an issue that tracks all the missing operations? If not, create one and link any other issues that mentions parts of it. Add a checklist with all the missing operations to that issue.

[zsolt-kolbay-sonarsource]

#7091
I did not add for compound assignment - as it doesn't make much sense here -, nor for ThrowExpression. This seems to work fine:

public void ThrowExpression(object o)
{
    _ = o ?? throw new NullReferenceException(nameof(o));
    o.ToString();
}

[martin-strecker-sonarsource]

Please link to #7039 in the issue as well. Please add all cases we discussed so far. Even if they are working already, we need to make sure we have all cases under test. "This seems to work fine." is not enough.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication