We consider the docker image as a separate component from the sonar-scanner-cli ZIP distribution, having its own release scheme. It has not always been the case. Before the 10.x release, the two components had the same release cycle. This created bad user experience when we had to release a breaking change of the docker image under the same tag.
The version of sonar-scanner-cli is hardcoded in the Dockerfile of this repository and must be updated in master branch.
If needed, prepare PR of Docker Hub documentation https://github.com/docker-library/docs
Note: Please use your own fork like seen in this closed PR
To create a good PR:
- The markdown format must follow a certain standard, otherwise automated tests will fail. You can test with the
markdownfmt.sh
tool included in the repository, for example./markdownfmt.sh -d sonar-scanner-cli/content.md
will output the diff that would have to be done to make the tests pass. You can use thepatch
command to apply the changes, for example:./markdownfmt.sh -d sonar-scanner-cli/content.md | patch sonar-scanner-cli/content.md
- Verify the Pull Request passes the automated tests (visible in the status of the PR)
To control the generated content of the Docker Hub page, look around in the files in .template-helpers
of the [docs
repository][docs]. For example, the "Where to get help" section is customized by a copy of .template-helpers/get-help.md
in sonar-scanner-cli/get-help.md
.
Until sonar-scanner-cli is released and the public artifacts are available, keep your PR a draft PR to make it clear it is not ready to be merged yet.
For more and up to date documentation, see https://github.com/docker-library/docs.
In order to update the Docker Hub images, a Pull Request must be created on the official-images repository.
To do so you should use your own personal fork
Create a feature branch on the fork:
GitCommit
must be updated to this repository master branch's HEAD.Tags
andDirectory
must be added/updated appropriately for each edition- see https://github.com/docker-library/official-images/pull/8837/files as an example
Until sonar-scanner-cli is released and the public artifacts are available, keep your PR a draft PR to make it clear it is not ready to be merged yet.
- Create the PR here
- If the documentation was updated in the step before, reference that PR in this PR.
- Click on compare across fork to be able to use the fork as head repository.
For more and up to date documentation, see https://github.com/docker-library/official-images.
The commit referenced in the DockerHub Pull Request must be tagged with the sonar-scanner-cli version.