Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM: Remove dependency on the foundry fork #498

Closed
bkolad opened this issue Jul 17, 2023 · 3 comments
Closed

EVM: Remove dependency on the foundry fork #498

bkolad opened this issue Jul 17, 2023 · 3 comments
Labels

Comments

@bkolad
Copy link
Member

bkolad commented Jul 17, 2023

Our dependency, the foundry crate, is encountering issues during the building process. see: foundry-rs/foundry#5409.
To address this, we have implemented a temporary solution by forking the dependency and addressing the issue in pull request #496.
Once the changes from foundry-rs/foundry#5397 are merged, we should remove the dependencies on the fork.

@bkolad bkolad added the evm label Jul 17, 2023
@bkolad bkolad changed the title Remove dependency on the foundry fork EVM: Remove dependency on the foundry fork Jul 17, 2023
@bkolad
Copy link
Member Author

bkolad commented Jul 21, 2023

The changes ware merged in foundry-rs , upgrading our dependency causes the following error:

error[E0658]: use of unstable library feature 'is_terminal'
  --> /Users/blaze/.cargo/git/checkouts/foundry-f7cca724e93059b0/02e430c/common/src/term.rs:11:22
   |
11 |     io::{prelude::*, IsTerminal},
   |                      ^^^^^^^^^^
   |
   = note: see issue #98070 <https://github.com/rust-lang/rust/issues/98070> for more information
   = help: add `#![feature(is_terminal)]` to the crate attributes to enable

error[E0658]: use of unstable library feature 'is_terminal'
  --> /Users/blaze/.cargo/git/checkouts/foundry-f7cca724e93059b0/02e430c/common/src/term.rs:41:61
   |
41 |         TermSettings { indicate_progress: std::io::stdout().is_terminal() }

To be investigated.

@neysofu
Copy link
Member

neysofu commented Jul 21, 2023

Starting from commit foundry-rs/foundry@058182d Foundry requires rustc 1.70, which stabilized IsTerminal. The last 1.69-compatible commit is foundry-rs/foundry@e41318d.

@neysofu
Copy link
Member

neysofu commented Aug 21, 2023

Fixed by #574.

@neysofu neysofu closed this as completed Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants