Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewarded_address in StateTransition is hard coded #647

Closed
citizen-stig opened this issue Aug 11, 2023 · 2 comments
Closed

rewarded_address in StateTransition is hard coded #647

citizen-stig opened this issue Aug 11, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@citizen-stig
Copy link
Member

citizen-stig commented Aug 11, 2023

As for today, reward address is hard coded to be address of sequencer.

There are couple problems with it:

  • Impossibility to have rewards to be sent to different address rather than sequencer.
  • It is unclear if rewards are DA layer currency or Rollup currency. If it is rollup currency, then it should be rollup address.

Original PR: #598

@citizen-stig citizen-stig added the bug Something isn't working label Aug 11, 2023
@theochap
Copy link
Contributor

I don't have strong opinions about what the reward address should be. I think it should indeed be dynamic instead of hardcoded (specially for the based sequencing feature), and when it comes to the currency I think it doesn't really matter (but need to double check with @preston-evans98 )

@preston-evans98
Copy link
Member

Yep, the rewarded address should definitely be dynamic. And it doesn't matter to me which format it is in - either a DA address or the corresponding rollup address is fine. Whichever is most natural for the module that needs to consume it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants