Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix flaky tests #258

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

🐛 Fix flaky tests #258

wants to merge 9 commits into from

Conversation

guettli
Copy link
Contributor

@guettli guettli commented Sep 9, 2024

What this PR does / why we need it:

The tests are flaky. This is easy to reproduce. CI often fails and re-running the tests usually solve the issue.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #257

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

Signed-off-by: Thomas Guettler <thomas.guettler@syself.com>
Signed-off-by: Thomas Guettler <thomas.guettler@syself.com>
Signed-off-by: Thomas Guettler <thomas.guettler@syself.com>
Signed-off-by: Thomas Guettler <thomas.guettler@syself.com>
Signed-off-by: Thomas Guettler <thomas.guettler@syself.com>
Signed-off-by: Thomas Guettler <thomas.guettler@syself.com>
Signed-off-by: Thomas Guettler <thomas.guettler@syself.com>
Signed-off-by: Thomas Guettler <thomas.guettler@syself.com>
Signed-off-by: Thomas Guettler <thomas.guettler@syself.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests are flaky: ClusterAddonReconciler [AfterEach] Basic test applies the helm chart
1 participant