Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Dark Theme and Light Theme #52

Open
Sparker0i opened this issue Dec 8, 2018 · 5 comments
Open

Proposal: Dark Theme and Light Theme #52

Sparker0i opened this issue Dec 8, 2018 · 5 comments
Labels
kwoc-moderate Possible project for KWoC

Comments

@Sparker0i
Copy link
Owner

Well, I did think about this a lot, but finally I have decided to ditch the dark blue color my app had for a long time, and it's now going to be either light or dark.

Dark Mode will have a dark grey background and white text, whereas Light Mode will have a White Background with Black text.

Though this may look easy while writing, implementing this is definitely going to take a lot of time. I can't say when it will arrive, but it will.

@codersanjeev
Copy link

Have you checked DayNight mode using AppCompatDelegate? I think we can implement this using that...
https://www.journaldev.com/19352/android-daynight-theme-night-mode#what-is-appcompatdelegate

@Sparker0i
Copy link
Owner Author

Thanks for this. Will look into it later.

@codersanjeev
Copy link

Can I start working on it ? @Sparker0i

@Sparker0i
Copy link
Owner Author

Sparker0i commented Dec 16, 2018

To be honest I'm split on this one. I believe the dark theme will definitely look good, but I'm not so sure whether black text (Icons,text etc) over white looks great.

Maybe will have to change the icons' colors to anything else other than black/white if we were to implement this.

@Sparker0i
Copy link
Owner Author

You can try this though @thedevelopersanjeev

@Sparker0i Sparker0i added the kwoc-moderate Possible project for KWoC label Dec 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kwoc-moderate Possible project for KWoC
Projects
None yet
Development

No branches or pull requests

2 participants