-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linkedin api v2 implementation #23
Comments
Hi, Here a few info I gathered... You can go to the conclusion down below. API changes analysis
(Thank you LinkedIn for this great description of your new API) Error handlingThe new return message for error has changed from:
to:
Not a big deal to change. I see the app permissions are the same. AuthenticationSeems like nothing has changed for OAuth. GeneralAbout REST methods it looks like somebody invented REST again. Yeepee. The API is JSON only now. Few more info: protocol info URNs & IDs
They created something funny. Again. Should not be too hard to implement. More docs: Common URNs & Namespaces, RFC 2141 FieldsThey changed the way fields works. That is not very nice. DecorationsThat is quite surprising. Paged responsesNew pagination arguments. Peoples APIsI see many changes in the data structures. Localization. Fields. Organizations and BrandsMany changes. Share and Social StreamMany changes. Very obscure (just as before). ConclusionThey made too many changes in the API.
The big ways:
I will not be able to support those changes. This library is getting old by the way. I think the community should start anew with a clean project with support for dotnet core. Thank you everyone for your support 👍 If any new project starts and gets support, please post the link here so I can reference it. |
Hi Sandrock, Meanwhile I started to change the project to use v2 so I took your project and rewrote the xml and some stuffs to support linkedin api v2. Currently only some endpoints are supported like basic person, company and share api. Pushed the changes to the forked project: |
Ok. Cool. 👍 You should try to keep the V1 code untouched in order to have a library that is able to use both APIs. I recommend to duplicate the code generation thingy and make it work for V2. |
I'm planning to archive this repository. If you have any request about the README or nuget package, here is the final call. Should a I publish a final nuget containing incentive to switch to another project? Is there any fork I should promote in the README? |
Hi SandRock,
I would like to contribute on implementing Linkedin api v2. Do you have any concept on your mind how we should start it?
As i saw in Linkedin documentation there are quite major changes on return types too (e.g. check firstName field on Profile) not just on endpoints.
I was thinking to change/ add the xml. Maybe we will need to add an extra xml level to support for return types. And also need some modification how to generate the code.
For dynamic fields like firsName (on Profile) we could simply use JObject (or this needs more rethinking).
Cheers,
Levente
The text was updated successfully, but these errors were encountered: