Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Telegram Support #3

Open
The-EpaG opened this issue Mar 6, 2024 · 2 comments
Open

Adding Telegram Support #3

The-EpaG opened this issue Mar 6, 2024 · 2 comments
Assignees

Comments

@The-EpaG
Copy link
Contributor

The-EpaG commented Mar 6, 2024

I would like to propose adding Telegram support to the project. I have forked the repository to work on this feature and would like to discuss the possibility of integrating it through a pull request.

Current Issues:
Currently, I have implemented a preliminary version of Telegram support for personal use, but it is affected by two bugs:

  1. Receiving Images Instead of Videos or Images: When sending a video or image via Telegram, I always receive an image, likely due to forced conversion to the JPEG format. This may be because Telegram has a limited range of MIME types compared to Blender.

image

  1. Duplicate File Sending via Email: After converting images, the files sent via email are always two instead of one. At the moment, I do not have theories regarding this behavior.

image

Request:
I ask the project maintainers if they agree with adding Telegram support and if they have any ideas on what in my code could be causing these issues. I am available to discuss further and collaborate to resolve these problems.

Thank you for your attention.

@SpectralVectors
Copy link
Owner

I took a quick look at the code, nothing jumped out at me as to why the image would be sent twice. The obvious clue seems to be that one is named donuts.png while the other is noname, so it seems to be sending before or after it is renamed, but I couldn't immediately tell where that was happening.

Telegram support sounds good to me, I'm not a Telegram user, but it seems like a natural extension.

At one point during dev I also had MMS included, but the delay was so long I decided to remove it, but the more protocols that are supported the better.

@The-EpaG
Copy link
Contributor Author

The-EpaG commented Mar 7, 2024

Thank you for taking a look at the code and for your support in adding Telegram support to the project. I agree that having more supported protocols can enhance overall usability.

Regarding the issue of files being sent twice via email, I acknowledge your observation regarding the file names. I will conduct further checks in the code to identify the point at which the double sending occurs and resolve it.

Regarding the problem of sending images instead of videos or images via Telegram, I will continue to investigate to find a solution. It may be necessary to delve deeper into how Telegram handles MIME types and whether there are settings that could affect file conversion.

It will take some time to resolve both issues, but if you assign me the issue, I will commit to finding a solution and submitting a pull request once resolved.

Thank you again for your support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants