Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

credential_offer_uri= hosted credential url should be uri encoded in the credential offer #102

Open
TimoGlastra opened this issue Mar 17, 2024 · 0 comments
Open

credential_offer_uri= hosted credential url should be uri encoded in the credential offer #102

TimoGlastra opened this issue Mar 17, 2024 · 0 comments

Comments

@TimoGlastra
Copy link
Collaborator

Currently it is generated as e.g.:

openid-credential-offer://?credential_offer_uri=https://3767-217-123-18-26.ngrok-free.app/oid4vci/e451c49f-1186-4fe4-816d-a942151dfd59/offers/b1b39c88-6003-464f-bc1b-1f164fa45d59

While I think it should be:

openid-credential-offer://?credential_offer_uri=https%3A%2F%2F3767-217-123-18-26.ngrok-free.app%2Foid4vci%2Fe451c49f-1186-4fe4-816d-a942151dfd59%2Foffers%2Fb1b39c88-6003-464f-bc1b-1f164fa45d59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TimoGlastra