Tests: adjust TODO after improving configuration merging in library

See owasp-modsecurity/ModSecurity#1990 for details.
owasp-modsecurity · Jan 9, 2019 · d7101e1 · d7101e1
1 parent 582410b
commit d7101e1
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 8 deletions.
diff --git a/tests/modsecurity-config-merge.t b/tests/modsecurity-config-merge.t
@@ -162,9 +162,6 @@ $t->plan(10);
 like(http_get_body('/', 'GOOD BODY'), qr/TEST-OK-IF-YOU-SEE-THIS/, "http level defaults, pass");
 like(http_get_body('/', 'VERY BAD BODY'), qr/403 Forbidden/, "http level defaults, block");
 
-TODO: {
-local $TODO = 'not yet, see https://github.com/SpiderLabs/ModSecurity/pull/1990';
-
 like(http_get_body('/modsec-disabled', 'VERY BAD BODY'), qr/TEST-OK-IF-YOU-SEE-THIS/, "location override for SecRuleEngine, pass");
 like(http_get_body('/nobodyaccess', 'VERY BAD BODY'), qr/TEST-OK-IF-YOU-SEE-THIS/, "location override for SecRequestBodyAccess, pass");
 like(http_get_body('/bodylimitprocesspartial', 'BODY' x 33), qr/TEST-OK-IF-YOU-SEE-THIS/, "location override for SecRequestBodyLimitAction, pass");
@@ -174,7 +171,6 @@ like(http_get_body('/server/modsec-disabled', 'VERY BAD BODY'), qr/TEST-OK-IF-YO
 like(http_get_body('/server/nobodyaccess', 'VERY BAD BODY'), qr/TEST-OK-IF-YOU-SEE-THIS/, "server override for SecRequestBodyAccess, pass");
 like(http_get_body('/server/bodylimitprocesspartial', 'BODY' x 33), qr/TEST-OK-IF-YOU-SEE-THIS/, "server override for SecRequestBodyLimitAction, pass");
 like(http_get_body('/server/bodylimitincreased', 'BODY' x 64), qr/TEST-OK-IF-YOU-SEE-THIS/, "server override for SecRequestBodyLimit, pass");
-}
 
 ###############################################################################
 

diff --git a/tests/modsecurity-request-body.t b/tests/modsecurity-request-body.t
@@ -166,13 +166,9 @@ like(
         'POST with auth_request (request size < client_header_buffer_size), no preread'
 );
 
-TODO: {
-local $TODO = 'not yet';
-
 foreach my $method (('GET', 'POST', 'PUT', 'DELETE')) {
 like(http_req_body($method, '/bodylimitrejectserver', 'BODY' x 33), qr/403 Forbidden/, "$method request body limit reject, block (inherited SecRequestBodyLimit)");
 }
-}
 
 ###############################################################################