Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled Forced Dark Theme Support #150

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

ch8n
Copy link
Contributor

@ch8n ch8n commented Oct 12, 2021

Changelogs :

  1. Updated Style theme.JetQuotes to disable darkmodeAllowed flag to false

How to Test?

@Spikeysanju Tried forced dark theme from setting and developer option but was unable to produce image as shown in the Issue #122

Please also refer to this section of Official Channel Video - Dark Theme and let me know if theme and colors could also be the issue

- blocked forced dark theme
@ch8n
Copy link
Contributor Author

ch8n commented Oct 12, 2021

@Spikeysanju Please link issue to #122 and mark it as Hacktoberfest accepeted once done

Copy link
Owner

@Spikeysanju Spikeysanju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ch8n PR LGTM 👍. Working as expected!!

@Spikeysanju Spikeysanju linked an issue Oct 12, 2021 that may be closed by this pull request
@Spikeysanju Spikeysanju merged commit 5cf78fd into Spikeysanju:master Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color of quote and title in action bar is black in Dark theme
2 participants