Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding HTTP client of a Spine Web JavaScript client. #207

Closed
YegorUdovchenko opened this issue Jan 15, 2024 · 3 comments
Closed
Labels
Client JS Issues related to the `spine-web-client` library enhancement New feature or request

Comments

@YegorUdovchenko
Copy link
Collaborator

The current version of a Spine Web client for JavaScript provides a high-level API for interacting with a Spine-based backend and carries all HTTP-related functionality. It makes tricky to:

  • add custom HTTP headers, e.g. "Authorization";
  • use non-CORS request mode;
  • expand client to interact with custom backend endpoints (non "/command" or "/query" ) that use similar protocol, e.i. Protobuf request/response body and the same set of auth headers;

To solve above-mentioned issues in Pure Photos we use our custom implementation of HttpClient and inject it after Spine Web client instantiation.

@YegorUdovchenko YegorUdovchenko added enhancement New feature or request Client JS Issues related to the `spine-web-client` library labels Jan 15, 2024
@armiol
Copy link
Contributor

armiol commented Jan 15, 2024

@YegorUdovchenko I am not sure whether this is an old issue, or a new one. But just in case: #194.

@armiol
Copy link
Contributor

armiol commented Jan 15, 2024

It's been released with 1.9.0.

@YegorUdovchenko
Copy link
Collaborator Author

@YegorUdovchenko I am not sure whether this is an old issue, or a new one. But just in case: #194.

Sorry, missed this update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client JS Issues related to the `spine-web-client` library enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants