Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Switch stops process #902

Closed
geephile opened this issue Feb 22, 2021 · 5 comments
Closed

User Switch stops process #902

geephile opened this issue Feb 22, 2021 · 5 comments
Labels
bug A functionality or parts of a program that do not work as intended help wanted Issues that need help since the assigned person has little to no knowledge about the topic pinned Apply to make stale bot ignore issue/PR. reproducibility: easy An issue that is easily reproduced

Comments

@geephile
Copy link

geephile commented Feb 22, 2021

As soon as a 2nd user tries to connect the spotifyd process stops without an error (looks like a clean shutdown).
Not sure if this is a bug or a "feature" or an "works as intended"

Environment

  • OS: Debian 11 (Bullseye/Testing) with pulseaudio backend
  • Spotifyd: 0.30 (full and slim prebuild)
  • Mutiple users with their own spotify premium accounts

Expected behaviour:

  • Run spotifyd without -u/-p options
  • User A connects
  • User A issues command to start music
  • Spotifyd starts playing music from User A
  • User B Connects
  • User B issues command to start music
  • Spotifyd stops playing music from User A
  • Spotifyd starts playing music from User B

Observed behaviour
Situation 1

  • Running spotifyd without -u/-p options
  • First user (A or B) that connects can play music
  • as soon as the other user connects after that, the spotifyd process closes

Situation 2

  • Running spotifyd with -u/-p options (credentails of user A)
  • as soon as user (B) connects the spotifyd process closes
  • as long as a user with the -u/-p credentials connects he (or she) can play music

Logs (last bit)

Click to show logs ``` drop Spirc[0] Shutting down player thread ... drop Player[0] drop Session[0] drop AudioKeyManager drop ChannelManager drop MercuryManager shutdown; state=pool::State { lifecycle: Running, num_futures: 0 } -> transitioned to shutdown -> shutting down workers dropping I/O source: 3 deregistering handle with poller dropping I/O source: 1 deregistering handle with poller dropping I/O source: 2 deregistering handle with poller dropping I/O source: 0 drop Dispatch deregistering handle with poller dropping I/O source: 5 ```
@geephile geephile added the bug A functionality or parts of a program that do not work as intended label Feb 22, 2021
@robinvd robinvd added pinned Apply to make stale bot ignore issue/PR. reproducibility: easy An issue that is easily reproduced help wanted Issues that need help since the assigned person has little to no knowledge about the topic labels Mar 3, 2021
@robinvd
Copy link
Contributor

robinvd commented Mar 3, 2021

I have found this as well, but no quick fix for this yet

@geephile
Copy link
Author

geephile commented May 29, 2021

Version 0.3.2 has the same issue
Fixed it at the moment with an auto restart by systemd.
first connect kills the process, and the 2nd try connects to restarted process

(my spotifyd.service file)

[Unit]
Description=Spotifyd deamon
StartLimitIntervalSec=20
StartLimitBurst=20
Wants=sound.target
After=sound.target
Wants=network-online.target
After=network-online.target

[Service]
User=spotifyd
Group=spotifyd

Restart=always
ExecStart=/opt/spotifyd-linux-full/spotifyd -d Woonkamer -b pulseaudio --zeroconf-port 4070 --initial-volume 60 -B 320 --no-daemon

[Install]
WantedBy=multi-user.target

@geephile
Copy link
Author

librespot-org/librespot#579
The original library seems to have the same issue

@eladyn
Copy link
Member

eladyn commented Oct 2, 2022

If I'm not mistaken, this has been fixed in #1059.

@eladyn eladyn closed this as completed Oct 2, 2022
@geephile
Copy link
Author

I can confirm that this issue is fixed (at least in a compile from the current source)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A functionality or parts of a program that do not work as intended help wanted Issues that need help since the assigned person has little to no knowledge about the topic pinned Apply to make stale bot ignore issue/PR. reproducibility: easy An issue that is easily reproduced
Projects
None yet
Development

No branches or pull requests

3 participants