From 319596e4263707f4bcf79d8c8c6b22e2aabd3224 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicol=C3=B2=20Avanzini?= Date: Wed, 9 Mar 2022 22:51:29 +0100 Subject: [PATCH 1/4] Allow XTRIM maxLength equal 0 --- src/StackExchange.Redis/RedisDatabase.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/StackExchange.Redis/RedisDatabase.cs b/src/StackExchange.Redis/RedisDatabase.cs index b951bef0a..7b3fb74f9 100644 --- a/src/StackExchange.Redis/RedisDatabase.cs +++ b/src/StackExchange.Redis/RedisDatabase.cs @@ -3402,9 +3402,9 @@ private Message GetSingleStreamReadMessage(RedisKey key, RedisValue afterId, int private Message GetStreamTrimMessage(RedisKey key, int maxLength, bool useApproximateMaxLength, CommandFlags flags) { - if (maxLength <= 0) + if (maxLength < 0) { - throw new ArgumentOutOfRangeException(nameof(maxLength), "maxLength must be greater than 0."); + throw new ArgumentOutOfRangeException(nameof(maxLength), "maxLength must be equal or greater than 0."); } var values = new RedisValue[2 + (useApproximateMaxLength ? 1 : 0)]; From 7d697954cecbcdcff533a220bc65f6848acb27a8 Mon Sep 17 00:00:00 2001 From: Nick Craver Date: Wed, 9 Mar 2022 22:14:09 -0500 Subject: [PATCH 2/4] Update src/StackExchange.Redis/RedisDatabase.cs --- src/StackExchange.Redis/RedisDatabase.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/StackExchange.Redis/RedisDatabase.cs b/src/StackExchange.Redis/RedisDatabase.cs index 7b3fb74f9..1aa3a84d0 100644 --- a/src/StackExchange.Redis/RedisDatabase.cs +++ b/src/StackExchange.Redis/RedisDatabase.cs @@ -3404,7 +3404,7 @@ private Message GetStreamTrimMessage(RedisKey key, int maxLength, bool useApprox { if (maxLength < 0) { - throw new ArgumentOutOfRangeException(nameof(maxLength), "maxLength must be equal or greater than 0."); + throw new ArgumentOutOfRangeException(nameof(maxLength), "maxLength must be equal to or greater than 0."); } var values = new RedisValue[2 + (useApproximateMaxLength ? 1 : 0)]; From c05d41723c039302cfea8dd299146e97e5ff1c3e Mon Sep 17 00:00:00 2001 From: Nick Craver Date: Wed, 9 Mar 2022 22:20:14 -0500 Subject: [PATCH 3/4] Add release notes --- docs/ReleaseNotes.md | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/ReleaseNotes.md b/docs/ReleaseNotes.md index a6f8cdb08..18c817a9d 100644 --- a/docs/ReleaseNotes.md +++ b/docs/ReleaseNotes.md @@ -4,6 +4,7 @@ - Fix [#1988](https://github.com/StackExchange/StackExchange.Redis/issues/1988): Don't issue `SELECT` commands if explicitly disabled ([#2023 by NickCraver](https://github.com/StackExchange/StackExchange.Redis/pull/2023)) - Adds: `ConfigurationOptions.BeforeSocketConnect` for configuring sockets between creation and connection ([#2031 by NickCraver](https://github.com/StackExchange/StackExchange.Redis/pull/2031)) +- Fix: Allow `XTRIM` `MAXLEN` argument to be `0` ([#2030 by NicoAvanzDev](https://github.com/StackExchange/StackExchange.Redis/pull/2030)) ## 2.5.43 From bd37f5be2abd2f071842cdda9f38f65b5ac15c11 Mon Sep 17 00:00:00 2001 From: Nick Craver Date: Wed, 9 Mar 2022 22:20:35 -0500 Subject: [PATCH 4/4] ehhhhhh, ordering --- docs/ReleaseNotes.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/ReleaseNotes.md b/docs/ReleaseNotes.md index 18c817a9d..53e00ecae 100644 --- a/docs/ReleaseNotes.md +++ b/docs/ReleaseNotes.md @@ -3,8 +3,8 @@ ## Unreleased - Fix [#1988](https://github.com/StackExchange/StackExchange.Redis/issues/1988): Don't issue `SELECT` commands if explicitly disabled ([#2023 by NickCraver](https://github.com/StackExchange/StackExchange.Redis/pull/2023)) -- Adds: `ConfigurationOptions.BeforeSocketConnect` for configuring sockets between creation and connection ([#2031 by NickCraver](https://github.com/StackExchange/StackExchange.Redis/pull/2031)) - Fix: Allow `XTRIM` `MAXLEN` argument to be `0` ([#2030 by NicoAvanzDev](https://github.com/StackExchange/StackExchange.Redis/pull/2030)) +- Adds: `ConfigurationOptions.BeforeSocketConnect` for configuring sockets between creation and connection ([#2031 by NickCraver](https://github.com/StackExchange/StackExchange.Redis/pull/2031)) ## 2.5.43