Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(commonmark) Header html tags in table cells do not round-trip or preview properly #183

Open
yellis opened this issue Jul 14, 2022 · 0 comments
Labels
bug Something isn't working commonmark Relates to commonmark round-tripping or syntax

Comments

@yellis
Copy link
Contributor

yellis commented Jul 14, 2022

Describe the bug
Header html tags used in table header or body cells end up not previewing properly in RT mode and mangle the table upon round-trip. It works in current editor when saved to the site - renders properly.

To Reproduce

  1. MD mode, create table, add an h1 html tag in any cell around the text
  2. Go to RT mode, observe that the tag has been transformed as a literal
  3. Go back to MD mode and the table syntax is all messed up and mangled

Expected behavior
Ideally we would support header elements in table cells. The GH MD table spec does not mention it, but the current editor and on-side rendering support it. If we decide not to support it, should at least allow round-trip without destroying the table markdup.

Screenshots
demo

Desktop (please complete the following information):
Windows 11 Chrome 103

Additional context

@yellis yellis added bug Something isn't working commonmark Relates to commonmark round-tripping or syntax labels Jul 14, 2022
@yellis yellis moved this to Todo in Stacks-Editor Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working commonmark Relates to commonmark round-tripping or syntax
Projects
Status: Todo
Development

No branches or pull requests

1 participant