Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: set currentIndex from route on Web Platform #963

Merged
merged 7 commits into from
May 31, 2023
Merged

feat: set currentIndex from route on Web Platform #963

merged 7 commits into from
May 31, 2023

Conversation

ferrarafer
Copy link
Contributor

@ferrarafer ferrarafer commented May 31, 2023 •
edited
Loading

Closes #911

@ferrarafer
Add RouterServiceInterface to Stacked package
8c5a15c
@ferrarafer
Add setCurrentWebPageIndex method to IndexTrackingViewModel
aa6ba52
@ferrarafer
Update cupertino_icons on example apps
4d40bc2
@ferrarafer
Sort routes to match BottomNavigation items order
68ea77c
@ferrarafer
Call setCurrentWebPageIndex on Class Constructor
4089dac 
Allows to set the index of the Bottom Navigation Bar using the current
route at Web Platform when app starts from scratch which means there is
no state for the currentIndex property to track the selected button.
@ferrarafer
Fix format
050c882
@github-actions
Copy link

github-actions bot commented May 31, 2023 •
edited
Loading

LCOV of commit d88e6a9 during Test Package #55

Summary coverage rate:
  lines......: 7.8% (291 of 3723 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                                                             |Lines       |Functions  |Branches    
  Filename                                                                   |Rate     Num|Rate    Num|Rate     Num
  =================================================================================================================
  lib/src/view_models/index_tracking_viewmodel.dart                          |92.3%     26|    -     0|    -      0
  lib/src/view_models/view_model_builder.dart                                | 0.0%     67|    -     0|    -      0

FilledStacks
FilledStacks approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@FilledStacks FilledStacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the comment this looks good.

lib/src/router/router_service_interface.dart Show resolved Hide resolved
@FilledStacks FilledStacks merged commit cfd1378 into master May 31, 2023
@FilledStacks FilledStacks deleted the feat/set-current-index-from-route-on-web-platform branch May 31, 2023 13:35
FilledStacks pushed a commit that referenced this pull request May 31, 2023
@semantic-release-bot
chore(release): 3.4.0 [skip ci]
b269348 
# [3.4.0](v3.3.0...v3.4.0) (2023-05-31)

### Features

* set currentIndex from route on Web Platform ([#963](#963)) ([cfd1378](cfd1378))
@FilledStacks
Copy link
Contributor

🎉 This PR is included in version 3.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sebastianbuechler sebastianbuechler mentioned this pull request Aug 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FilledStacks FilledStacks FilledStacks approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug]: bottom nav bar example shows wrong selected nav bar item after browser refresh
2 participants
@ferrarafer @FilledStacks