Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update router example #967

Merged
merged 7 commits into from
Jun 21, 2023
Merged

Conversation

ferrarafer
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Jun 5, 2023

LCOV of commit 3a9c114 during Test Package #56

Summary coverage rate:
  lines......: 7.8% (291 of 3723 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

Copy link
Contributor

@FilledStacks FilledStacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@FilledStacks FilledStacks merged commit 012891f into pre-release Jun 21, 2023
@FilledStacks FilledStacks deleted the chore/update-router-example branch June 21, 2023 12:04
ferrarafer added a commit that referenced this pull request Jun 22, 2023
refactor: IndexTrackingViewModel (#973)

* Add RouterServiceInterface to Stacked package
* Add setCurrentWebPageIndex method to IndexTrackingViewModel
* Update cupertino_icons on example apps
* Sort routes to match BottomNavigation items order
* Call setCurrentWebPageIndex on Class Constructor

Allows to set the index of the Bottom Navigation Bar using the current
route at Web Platform when app starts from scratch which means there is no state for the currentIndex property to track the selected button.

chore: Update router example (#967)

* Update router_example to test InitializableSingleton
FilledStacks pushed a commit that referenced this pull request Jun 22, 2023
## [3.4.1](v3.4.0...v3.4.1) (2023-06-22)

### Bug Fixes

* expose setCurrentWebPageIndex on IndexTrackingStateHelper ([#976](#976)) ([2057589](2057589)), closes [#973](#973) [#967](#967)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants