-
-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update router example #967
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows to set the index of the Bottom Navigation Bar using the current route at Web Platform when app starts from scratch which means there is no state for the currentIndex property to track the selected button.
Update example Squash
LCOV of commit
|
FilledStacks
approved these changes
Jun 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome
ferrarafer
added a commit
that referenced
this pull request
Jun 22, 2023
refactor: IndexTrackingViewModel (#973) * Add RouterServiceInterface to Stacked package * Add setCurrentWebPageIndex method to IndexTrackingViewModel * Update cupertino_icons on example apps * Sort routes to match BottomNavigation items order * Call setCurrentWebPageIndex on Class Constructor Allows to set the index of the Bottom Navigation Bar using the current route at Web Platform when app starts from scratch which means there is no state for the currentIndex property to track the selected button. chore: Update router example (#967) * Update router_example to test InitializableSingleton
FilledStacks
pushed a commit
that referenced
this pull request
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.