Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong prepare comment when default creation trigger used #71

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

jreimone
Copy link
Contributor

@jreimone jreimone commented Nov 8, 2023

Type of Change

  • Bugfix
  • Enhancement / new feature
  • Refactoring
  • Documentation

Description

As can be seen in this prepare comment the device spec is added even the default create comment (without android or ios) was used here. The wrong part of the prepare comment is the following:

"device": {
    "os": "@bot-testio",
    "category": "exploratory-test",
    "min": "8.0",
    "max": "10"
  }

This shouldn't be there for the default create comment. More precisely, os and category are completely wrong.

The root cause of the bug is that the CREATE_COMMENT_PREFIX we use in the implementation to split up the creation comment contained a trailing space. Thus, wrong data was extracted. This fix removes the trailing space.

Checklist

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Review the Contributing Guideline and sign CLA
  • Reference relevant issue(s) and close them after merging

@jreimone jreimone requested a review from a team November 8, 2023 08:33
@jreimone jreimone added the bug Something isn't working label Nov 8, 2023
@jreimone jreimone enabled auto-merge November 8, 2023 08:33
Copy link

sonarqubecloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jreimone jreimone merged commit 70551bf into main Nov 8, 2023
4 checks passed
@jreimone jreimone deleted the fix-prepare-comment-bug branch November 8, 2023 09:08
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants