Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup AWS CloudFormation to Deploy Redirect Endpoint to Installation #40

Open
romeara opened this issue Oct 7, 2018 · 1 comment
Open

Setup AWS CloudFormation to Deploy Redirect Endpoint to Installation #40

romeara opened this issue Oct 7, 2018 · 1 comment
Labels
enhancement

Comments

@romeara
Copy link
Member

romeara commented Oct 7, 2018

Setup a consistent API endpoint that can be referenced by the static HTML page to redirect to the GitHub installation page
@romeara
Copy link
Member Author

romeara commented Nov 3, 2018

We are currently instead code this into the HTML for each website, so this isn't needed in the MVP - however in the future the URL will be potentially dynamic (once the GitHub App is infrastructure-as-code), so we'll need to do this somehow.

We could possibly leave a placeholder variable in that spot, and "build" the HTML prior to upload or something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@romeara