jekyll-seo-tag does not seem to be supported #16

adius · 2017-08-31T19:37:54Z

 $ docker run -v "$PWD":/usr/src/app -p "4000:4000" starefossen/github-pages
Configuration file: /usr/src/app/_config.yml
Configuration file: /usr/src/app/_config.yml
            Source: /usr/src/app
       Destination: /_site
 Incremental build: enabled
      Generating...
  Liquid Exception: Liquid syntax error (line 16): Unknown tag 'seo' in /_layouts/default.html
jekyll 3.4.5 | Error:  Liquid syntax error (line 16): Unknown tag 'seo'

Starefossen · 2017-08-31T20:08:23Z

It should be installed already as a dependency of the github-pages gem. You would however need to enable it in your _config.yml like this:

gems:
- jekyll-seo-tag

adius · 2017-09-01T11:04:37Z

It is enabled 😕

adius · 2017-09-27T13:29:21Z

Any ideas?

siliconmeadow · 2017-09-28T07:48:03Z

@adius could you supply your _layouts/default.html file?

adius · 2017-09-28T08:34:55Z

@siliconmeadow Yes, but nothing interesting to see there

<!doctype html>
<html>
<head>
  <meta charset=utf-8 />
  <meta name=viewport content="width=device-width, initial-scale=1">
  <link rel=stylesheet media=all href=/css/screen.css>
  <link rel="shortcut icon" href=/img/favicon.png>
  <link
    rel=stylesheet
    href=//maxcdn.bootstrapcdn.com/font-awesome/4.3.0/css/font-awesome.min.css>
  <link
    href=/atom.xml
    rel=alternate
    title="Adrian Sieber"
    type=application/atom+xml>
  {% seo %}
</head>
<body>
…

siliconmeadow · 2017-09-28T08:54:19Z

I've never used this gem before, but looking at http://jekyll.github.io/jekyll-seo-tag/installation/ , it says that you need to add this prior to the <head> tag:

<!-- Begin Jekyll SEO tag v2.3.0 -->
<title>Installing Jekyll SEO Tag | Jekyll SEO Tag</title>
<meta property="og:title" content="Installing Jekyll SEO Tag" />
<meta property="og:locale" content="en_US" />
<meta name="description" content="A Jekyll plugin to add metadata tags for search engines and social networks to better index and display your site’s content." />
<meta property="og:description" content="A Jekyll plugin to add metadata tags for search engines and social networks to better index and display your site’s content." />
<link rel="canonical" href="http://jekyll.github.io/jekyll-seo-tag/installation/" />
<meta property="og:url" content="http://jekyll.github.io/jekyll-seo-tag/installation/" />
<meta property="og:site_name" content="Jekyll SEO Tag" />
<script type="application/ld+json">
{"name":null,"description":"A Jekyll plugin to add metadata tags for search engines and social networks to better index and display your site’s content.","author":null,"@type":"WebPage","url":"http://jekyll.github.io/jekyll-seo-tag/installation/","image":null,"publisher":null,"headline":"Installing Jekyll SEO Tag","dateModified":null,"datePublished":null,"sameAs":null,"mainEntityOfPage":null,"@context":"http://schema.org"}</script>
<!-- End Jekyll SEO tag -->

I don't know if that would help?

siliconmeadow · 2017-09-28T09:00:33Z

My mistake - just prior to the closing </head> tag - ignore my previous comment.

siliconmeadow · 2017-09-28T09:14:27Z

I'm looking through the issues, and it looks like others have an _includes/head/seo.html file which shows some other ways it appears they've defined {% seo %}.

What I'm wondering is whether the problem with the jekyll-seo-tag gem in your circumstance is not that the gem isn't installed in the docker image, but that it's not correctly invoked in your templates?

adius · 2017-09-28T09:17:09Z

No, I don't think so. I've been using the plugin before with https://github.com/github/pages-gem and it worked like a charm, but I'm sick of dealing with ruby & bundler issues and that's why I wanted to use a docker based solution...

Starefossen · 2017-09-28T19:08:23Z

Yeah, ruby and bundler is such a mess... 😠

smeyfroi · 2017-09-29T08:33:48Z

Long shot @adius but you might try stopping the container, deleting your Gemfile.lock and bringing docker up again to force bundler to start over. I had some weirdness with jekyll gems that went away when I blew the lock file away.

adius · 2017-09-29T09:58:54Z

Thanks a lot @smeyfroi. This wasn't exactly the problem, but it led me on the right way.
The problem was that I didn't have a Gemfile at all 🙈 . I thought it wasn't necessary, as all dependencies are already preinstalled in the docker container.

The Liquid Exception: Liquid syntax error (line 16): Unknown tag 'seo' in /_layouts/default.html error doesn't suggest that the Gemfile is missing either.

How should this be fixed? A warning if the Gemfile is missing? Or automatically adding one?

smeyfroi · 2017-09-29T10:05:08Z

@adius Nice!

It is confusing, and not really explained very well in the jekyll docs (that I could find anyway).

So perhaps document that both a Gemfile and the _config.yml gems declaration is required? New plugins require additions to both files.

Also maybe worth explaining that bundler is invoked during container startup: I found myself reading the Dockerfile to understand what was going on.

And the problem I had was with gem dependency conflicts that went away when I deleted the Gemfile.lock. So perhaps that's worth noting in the docs as well, as a troubleshooting thing?

Starefossen · 2017-09-30T17:31:02Z

Great writeput @smeyfroi 👍 We should definitely add this to the project README I think.

smeyfroi · 2017-10-02T08:32:05Z

I can take a look and raise a PR over the next couple days.

Starefossen self-assigned this Sep 3, 2017

smeyfroi mentioned this issue Oct 3, 2017

[NO MERGE] Add notes about installing plugins #31

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

jekyll-seo-tag does not seem to be supported #16

jekyll-seo-tag does not seem to be supported #16

adius commented Aug 31, 2017 •

edited

Loading

Starefossen commented Aug 31, 2017 •

edited

Loading

adius commented Sep 1, 2017

adius commented Sep 27, 2017

siliconmeadow commented Sep 28, 2017

adius commented Sep 28, 2017

siliconmeadow commented Sep 28, 2017

siliconmeadow commented Sep 28, 2017 •

edited

Loading

siliconmeadow commented Sep 28, 2017

adius commented Sep 28, 2017

Starefossen commented Sep 28, 2017

smeyfroi commented Sep 29, 2017

adius commented Sep 29, 2017

smeyfroi commented Sep 29, 2017

Starefossen commented Sep 30, 2017

smeyfroi commented Oct 2, 2017

jekyll-seo-tag does not seem to be supported #16

jekyll-seo-tag does not seem to be supported #16

Comments

adius commented Aug 31, 2017 • edited Loading

Starefossen commented Aug 31, 2017 • edited Loading

adius commented Sep 1, 2017

adius commented Sep 27, 2017

siliconmeadow commented Sep 28, 2017

adius commented Sep 28, 2017

siliconmeadow commented Sep 28, 2017

siliconmeadow commented Sep 28, 2017 • edited Loading

siliconmeadow commented Sep 28, 2017

adius commented Sep 28, 2017

Starefossen commented Sep 28, 2017

smeyfroi commented Sep 29, 2017

adius commented Sep 29, 2017

smeyfroi commented Sep 29, 2017

Starefossen commented Sep 30, 2017

smeyfroi commented Oct 2, 2017

adius commented Aug 31, 2017 •

edited

Loading

Starefossen commented Aug 31, 2017 •

edited

Loading

siliconmeadow commented Sep 28, 2017 •

edited

Loading