Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove set-output from Makefiles. #497

Closed
bryanpaget opened this issue Aug 9, 2023 · 4 comments · Fixed by #501
Closed

Remove set-output from Makefiles. #497

bryanpaget opened this issue Aug 9, 2023 · 4 comments · Fixed by #501
Assignees

Comments

@bryanpaget
Copy link
Contributor

bryanpaget commented Aug 9, 2023

I removed set-output from our Github Actions but we need to remove it from the Makefiles as well.

The following tickets have more information:

@bryanpaget bryanpaget self-assigned this Aug 9, 2023
@bryanpaget
Copy link
Contributor Author

If I have time, change set-output in other repos too or at least make a ticket for them.

@bryanpaget
Copy link
Contributor Author

This has proven difficult in practice while in theory it's just a syntax update.

Failing:

The above failing build boggles my mind since all I've done is change the following three lines:

Image

And you'd think it would either work or not work but it seems to work for the rstudio image but not work for the other images.

@bryanpaget
Copy link
Contributor Author

Update: I just noticed a missing $ on line 203. Rebuilding now.

@bryanpaget
Copy link
Contributor Author

Blocked by #502

@bryanpaget bryanpaget linked a pull request Aug 22, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant