Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Component: prob-notebook-controller #127

Closed
rohank07 opened this issue Jan 18, 2022 · 1 comment
Closed

Custom Component: prob-notebook-controller #127

rohank07 opened this issue Jan 18, 2022 · 1 comment
Assignees
@rohank07
Labels
size/S ~1 day

Comments

@rohank07
Copy link
Contributor

Overview

EPIC: Kubeflow Upgrade Planning

Component Local Manifests Path Upstream Initial Work
prob-notebook-controller custom/prob-notebook-controller v1.3.1
@rohank07 rohank07 added the size/S ~1 day label Jan 18, 2022
@rohank07 rohank07 mentioned this issue Jan 18, 2022
Closed
@sylus
Copy link
Member

sylus commented Jan 19, 2022

Hey I removed the prob-notebook-controller section since i was wrong about that. That is just a custom controller that we wrote / own and is wholly separate from the kubeflow manifests and handled via Argo already.

https://github.com/StatCan/aaw-argocd-manifests/blob/aaw-dev-cc-00/daaas-system/notebook-controllers/notebook-auth-policy-checker/manifest.yaml

However when we eventually do a CI run and want to test everything it will be good to know about this component so I'm tracking in this issue:

#132

@sylus sylus closed this as completed Jan 19, 2022
@rohank07 rohank07 self-assigned this Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohank07 rohank07

Labels
size/S ~1 day
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sylus @rohank07