Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WinConsole's tty check is inaccurate #62

Open
retep998 opened this issue Jun 26, 2016 · 1 comment
Open

WinConsole's tty check is inaccurate #62

retep998 opened this issue Jun 26, 2016 · 1 comment

Comments

@retep998
Copy link
Contributor

retep998 commented Jun 26, 2016

When using WinConsole::new() it takes an arbitrary writer, but then it doesn't check whether that writer is a console, instead it just gets a handle to the current console buffer, whatever it is, and applies attributes to that, assuming that is also the writer.

This leads to silly situations where if someone passes a writer to WinConsole::new() that isn't the windows console but a pipe or any other sort of writer, or even a console framebuffer that isn't the active one, term will still set the attributes on the console frame buffer that was active at the time WinConsole::new() was called.

@Stebalien
Copy link
Owner

Unfortunately, fixing this (along with most of the bugs here) really requires term to be rewritten. I've started this a few times but haven't really had time to come up with a design I'm happy with (impending thesis deadline).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants