Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to compile on win32 #33

Open
ctron opened this issue May 10, 2023 · 3 comments
Open

Fails to compile on win32 #33

ctron opened this issue May 10, 2023 · 3 comments

Comments

@ctron
Copy link

ctron commented May 10, 2023

Trying to compile, with defaults enabled, fails on windows:

Having:

xattr = "1"

Results in:

error[E0433]: failed to resolve: could not find `unix` in `os`
 --> C:\Users\runneradmin\.cargo\registry\src\git.luolix.top-1ecc6299db9ec823\xattr-1.0.0\src\util.rs:4:14
  |
4 | use std::os::unix::ffi::OsStrExt;
  |              ^^^^ could not find `unix` in `os`

error[E0433]: failed to resolve: could not find `unix` in `os`
  --> C:\Users\runneradmin\.cargo\registry\src\git.luolix.top-1ecc6299db9ec823\xattr-1.0.0\src\lib.rs:36:14
   |
36 | use std::os::unix::io::AsRawFd;
   |              ^^^^ could not find `unix` in `os`

error[E0433]: failed to resolve: could not find `unix` in `os`
 --> C:\Users\runneradmin\.cargo\registry\src\git.luolix.top-1ecc6299db9ec823\xattr-1.0.0\src\sys\unsupported.rs:3:14
  |
3 | use std::os::unix::io::RawFd;
  |              ^^^^ could not find `unix` in `os`

error[E0432]: unresolved import `UnsupportedPlatformError`
 --> C:\Users\runneradmin\.cargo\registry\src\git.luolix.top-1ecc6299db9ec823\xattr-1.0.0\src\sys\unsupported.rs:6:5
  |
6 | use UnsupportedPlatformError;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^ no external crate `UnsupportedPlatformError`

Some errors have detailed explanations: E0432, E0433.
For more information about an error, try `rustc --explain E0432`.
error: could not compile `xattr` due to 4 previous errors
warning: build failed, waiting for other jobs to finish...
@Stebalien
Copy link
Owner

Hm. I didn't really consider windows when I made this crate. I'll see what I can do but it could be a while till I get to it.

@damooo
Copy link

damooo commented Sep 5, 2023

It would be helpful to have windows support too, so that one can use same abstraction for native apps.

@Stebalien
Copy link
Owner

So, I can't support windows as extended attributes aren't a thing there (NTFS has "alternative streams", which is quite different). However, I can let the platform be treated as supported.

I'll bump the priority on this, but, if you have time, a patch would be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants