Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Objects at high zoom wobble — but only when atmosphere is on #2809

Closed
10110111 opened this issue Nov 1, 2022 · 5 comments
Closed

Objects at high zoom wobble — but only when atmosphere is on #2809

10110111 opened this issue Nov 1, 2022 · 5 comments
Assignees
Labels
enhancement Improve existing functionality
Milestone

Comments

@10110111
Copy link
Contributor

10110111 commented Nov 1, 2022

To reproduce, try the following steps:

  1. Launch Stellarium
  2. Make sure atmosphere is off
  3. Go to Thebe (or, if your max zoom setting is too small, try Callisto)
  4. Zoom in to see the ball, notice how clean and stable it is
  5. Turn atmosphere on...

The screenshots of Thebe, as an extreme example:

  • No atmosphere:

Screenshot - 021122 - 00:57:45

  • Atmosphere on (this is just one screenshot of a continuously wobbling image):

Screenshot - 021122 - 00:57:37

I would suppose a problem with precision of projection, but given that without atmosphere everything is OK, the problem apparently is elsewhere.

@10110111
Copy link
Contributor Author

10110111 commented Nov 1, 2022

I've found the problem: it's in the float-coarsening of the geometric angle of elevation in Refraction::innerRefractionForward that breaks things. I've tried removing all this coarsening from this method, so that calculations are all done in double, and now nothing wobbles.

@10110111 10110111 self-assigned this Nov 1, 2022
@gzotti
Copy link
Member

gzotti commented Nov 2, 2022

Thanks @10110111, that was the one case of float/double issue I mentioned I was intending to track down.

@gzotti gzotti added this to the 1.2 milestone Nov 12, 2022
@gzotti gzotti added the enhancement Improve existing functionality label Nov 12, 2022
@github-actions
Copy link

Hello @10110111!

Thank you for suggesting this enhancement.

@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Nov 20, 2022
@github-actions
Copy link

Hello @10110111!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Dec 25, 2022
@github-actions
Copy link

Hello @10110111!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality
Development

No branches or pull requests

3 participants