Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

odd canceling workflow [observing lists] #3587

Closed
axd1967 opened this issue Jan 10, 2024 · 4 comments
Closed

odd canceling workflow [observing lists] #3587

axd1967 opened this issue Jan 10, 2024 · 4 comments
Assignees
@gzotti
Labels
bug Something likely wrong in the code importance: low Small problem, rarely visible, no crash state: confirmed A developer can reproduce the issue
Milestone
24.1

Comments

@axd1967
Copy link
Contributor

axd1967 commented Jan 10, 2024

Expected Behaviour

When canceling an action, no error message should be issued.

Actual Behaviour

Error message given although the user didn't do anything wrong.

Steps to reproduce

  1. delete a list; click NO
  2. BUG: odd error message "you cannot delete the default or last list". this indicates oddities in the user action canceling logic. Why can't "the last list" be deleted?
  3. similarly, when canceling an export action, Stellarium says "Error: Cannot export"; this is unnecessary and confusing.

System

  • Stellarium version: Version 24.4.8-0de39da [master] Based on Qt 5.12.8

Logfile

If possible, attach the logfile log.txt from your user data directory. Look into the Guide for its location.
@alex-w alex-w added bug Something likely wrong in the code state: confirmed A developer can reproduce the issue importance: low Small problem, rarely visible, no crash labels Jan 10, 2024
@github-actions GitHub Actions
Copy link

Hello @axd1967!

OK, developers can reproduce the issue. Thanks for the report!

@gzotti
Copy link
Member

gzotti commented Jan 12, 2024

1: ACK
2: The last list and the default list cannot be deleted because there must be at least one list, and the default list is delete-protected. No bug, this is intentional.
3: ACK.

@gzotti gzotti self-assigned this Jan 12, 2024
@gzotti gzotti added this to the 24.1 milestone Jan 12, 2024
@gzotti gzotti closed this as completed in c642e44 Jan 12, 2024
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Jan 27, 2024
@github-actions GitHub Actions
Copy link

Hello @axd1967!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Mar 26, 2024
@github-actions GitHub Actions
Copy link

Hello @axd1967!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gzotti gzotti

Labels
bug Something likely wrong in the code importance: low Small problem, rarely visible, no crash state: confirmed A developer can reproduce the issue
Milestone
24.1
Development

No branches or pull requests
3 participants
@alex-w @axd1967 @gzotti