Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 'selectObjectByName' pointer changed to always being 'false' #3968

Closed
Austin-RR opened this issue Nov 3, 2024 · 11 comments
Closed

The 'selectObjectByName' pointer changed to always being 'false' #3968

Austin-RR opened this issue Nov 3, 2024 · 11 comments
Assignees
Labels
bug Something likely wrong in the code state: confirmed A developer can reproduce the issue subsystem: scripting The issue related to scripting engine of planetarium…
Milestone

Comments

@Austin-RR
Copy link

It appears the behaviour of selectObjectByName has changed unexpectedly when upgrading Stellarium from 24.2 to 24.3. The "pointer" parameter seems to always be set to "false" now.

I did a test by completely uninstalling Stellarium (and all custom user files) and then ran the following command immediately from a clean installation of Stellarium:

core.selectObjectByName("M31", true);

The same command above on version 24.2 displays the selection pointer while version 24.3 does not.

Installation files used for this test on my Windows 10 laptop:

  • stellarium-24.2-qt6-win64.exe
  • stellarium-24.3-qt6-win64.exe

I also seen the same result on my computer at work that runs Windows 11. I also tried the following latest snapshot, but I got the same result of the selection pointer never showing:
stellarium-24.3-44fb485-qt6-win64.exe

Thanks!

24 2

24 3

@alex-w alex-w added the subsystem: scripting The issue related to scripting engine of planetarium… label Nov 3, 2024
@alex-w
Copy link
Member

alex-w commented Nov 4, 2024

Please show value of viewing/flag_show_selection_marker in config.ini file

@Austin-RR
Copy link
Author

Hi Alex. Unfortunately, I am unable to find the flag_show_selection_marker option anywhere in my config.ini file. (I attached my 24.3 config file here as a TXT file.)

Just out of curiosity, I manually added flag_show_selection_marker = true under [Viewing] to the config file in my 24.3 installation. This edit did not help. The same test command I used in my original post still does not display the selection pointer. I do not know if this information helps at all, but I thought I would report it anyway. Thanks!

config.txt

@gzotti
Copy link
Member

gzotti commented Nov 4, 2024

Weird. It does not show in 24.3, but is OK again in current master.

@alex-w
Copy link
Member

alex-w commented Nov 4, 2024

Hello @Austin-RR!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w added this to the 24.4 milestone Nov 4, 2024
@alex-w alex-w added bug Something likely wrong in the code state: confirmed A developer can reproduce the issue labels Nov 4, 2024
Copy link

github-actions bot commented Nov 4, 2024

Hello @Austin-RR!

OK, developers can reproduce the issue. Thanks for the report!

@alex-w
Copy link
Member

alex-w commented Nov 4, 2024

Weird. It does not show in 24.3, but is OK again in current master.

I can confirm the issue in current master

@Austin-RR
Copy link
Author

Glad you confirmed the issue. It is not a huge issue for me as I can use something like this code as a temporary (until 24.4) fix to have a pointer drawn after selecting the object:

MarkerMgr.markerObject("M31",true,"dashed-square","#6c87db",20,false,0);

Thanks to everyone!

@alex-w alex-w self-assigned this Nov 5, 2024
@alex-w
Copy link
Member

alex-w commented Nov 6, 2024

OK, I found a bad guy (see commit 447acba) of course it will not work :-/

@alex-w alex-w closed this as completed in 5d7b257 Nov 6, 2024
@gzotti
Copy link
Member

gzotti commented Nov 6, 2024

Oops, sorry. I had not seen the pointer call in the end... Now added a docfix.

@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Nov 18, 2024
Copy link

Hello @Austin-RR!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Dec 22, 2024
Copy link

Hello @Austin-RR!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something likely wrong in the code state: confirmed A developer can reproduce the issue subsystem: scripting The issue related to scripting engine of planetarium…
Development

No branches or pull requests

3 participants