Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

47 Tuc image is doubled #3996

Closed
10110111 opened this issue Dec 4, 2024 · 10 comments
Closed

47 Tuc image is doubled #3996

10110111 opened this issue Dec 4, 2024 · 10 comments
Assignees
Labels
data Missing/bad/outdated data, but no code error
Milestone

Comments

@10110111
Copy link
Contributor

10110111 commented Dec 4, 2024

The following screenshot was done with stars and the Milky Way disabled. Two issues are apparent, compared with nebulae/default/smc29-2.png, which contains an image of 47 Tuc:

  1. Many of the stars have fainter copies nearby (enabling stars will show that there's one star instead of two);
  2. The middle of 47 Tuc is blown.

This may imply that there are two different images a bit displaced from each other (the blown middle would then be because of addition of two bright images). I tried disabing all DSS checkboxes, but this didn't change anything. Not sure how to find which image is the second one (the first one being made of smc29-*.png).

Screenshot_2024-12-04_17-46-54

@10110111
Copy link
Contributor Author

10110111 commented Dec 4, 2024

Removing smc29-2.png from the installation prefix confirms my conjecture about there being two images:

Screenshot_2024-12-04_18-01-10

Still need to find which is the second one.

@gzotti
Copy link
Member

gzotti commented Dec 4, 2024

SMC?

@10110111
Copy link
Contributor Author

10110111 commented Dec 4, 2024

SMC?

I have no idea about the naming scheme of the images.

@alex-w
Copy link
Member

alex-w commented Dec 4, 2024

Please remove texture for NGC104

@alex-w alex-w added this to the 24.4 milestone Dec 4, 2024
@alex-w
Copy link
Member

alex-w commented Dec 4, 2024

SMC = Small Magellanic Cloud

@alex-w alex-w added the data Missing/bad/outdated data, but no code error label Dec 4, 2024
@10110111
Copy link
Contributor Author

10110111 commented Dec 4, 2024

Please remove texture for NGC104

Yeah, that's it. After removing it along with smc29-2.png there are no remnants. Since the SMC texture has a better-resolution image of NGC104, I suppose we should simply remove n104.png completely.

@alex-w
Copy link
Member

alex-w commented Dec 4, 2024

Please update the CREDITS.md and textures.json files after removing texture also

@10110111
Copy link
Contributor Author

10110111 commented Dec 4, 2024

CREDITS.md doesn't appear to mention NGC104 in any form.

@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Dec 9, 2024
Copy link

github-actions bot commented Dec 9, 2024

Hello @10110111!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Dec 22, 2024
Copy link

Hello @10110111!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data Missing/bad/outdated data, but no code error
Development

No branches or pull requests

3 participants