Use ThrowHelper for exceptions

[SteveDunn]

No description provided.

[SteveDunn]

I'm still looking at this one, although I haven't been able to find a suitable bit of code that I can benchmark (in benchmark.net) that demonstrates any speed increase.

[SteveDunn]

I'm still looking at this one, although I haven't been able to find a suitable bit of code that I can benchmark (in benchmark.net) that demonstrates any speed increase.

Profiling this is quite tricky, although there are performance gains to be had, so this item should be implemented.

[Herdo]

@SteveDunn What's the purpose for this? Maintainability or performance?

[viceroypenguin]

Performance- using a helper method improves the rendered code from JIT.

https://docs.microsoft.com/en-us/windows/communitytoolkit/developer-tools/throwhelper#technical-details

[Herdo]

@viceroypenguin 👍 The ThrowHelper methods from CommunityToolkit.Diagnostics would only be used for the system exceptions then. Is that the only purpose, or should the ValueObjectValidationException receive a wrapper method as well, to benefit from the performance benefits?

[viceroypenguin]

Yes, other exceptions should be wrapped separately with a similar helper class to benefit from similar performance optimizations. All exceptions receive these optimizations, not just this library or the system exceptions - it's just that the system ones are the ones that make sense to put into CommunityToolkit.Diagnostics. Whether @SteveDunn wants to add a dependency to CommunityToolkit.Diagnostics or copy the relevant exceptions independently for Vogen is up to him.

[SteveDunn]

Looking at this one at long last! I don't really want to take a dependency on anything, so I'm thinking of generating a type that has all of the methods required for the exceptions that are thrown with Vogen.
I'm just wondering if this is something that has been, or is being, implemented in .NET 9.

[viceroypenguin]

Looking at this one at long last! I don't really want to take a dependency on anything, so I'm thinking of generating a type that has all of the methods required for the exceptions that are thrown with Vogen. I'm just wondering if this is something that has been, or is being, implemented in .NET 9.

For Vogen's case, I'd recommend having an internal static class with the helper methods. ThrowHelper or similar. In this case, I agree with avoiding the dependency on CommunityToolkit.Diagnostics, and you'll have to create your own methods for the Vogen exceptions anyway. Just my 2c.

[SteveDunn]

Implemented in 5.0.2